[GitHub] [incubator-superset] suddjian commented on a change in pull request #9714: fix bug where error at import dashboard fails to show toast in "welcome" app

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #9714:
URL: https://github.com/apache/incubator-superset/pull/9714#discussion_r420266915



##########
File path: superset-frontend/spec/javascripts/views/dashboardList/DashboardList_spec.jsx
##########
@@ -63,6 +63,14 @@ fetchMock.get(dashboardsEndpoint, {
   dashboard_count: 3,
 });
 
+const common = {

Review comment:
       `common` is declared and not used, is it meant to be in a test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org