You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2019/11/04 20:19:00 UTC

[jira] [Commented] (CALCITE-3458) Remove desc in AbstractRelNode

    [ https://issues.apache.org/jira/browse/CALCITE-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966975#comment-16966975 ] 

Julian Hyde commented on CALCITE-3458:
--------------------------------------

The line above, {{LOGGER.trace("Register {} in {}", rel.getDescription(), subset.getDescription())}}, is a problem. It calls {{getDescription()}} even when tracing is not enabled. It needs to be fixed.

> Remove desc in AbstractRelNode
> ------------------------------
>
>                 Key: CALCITE-3458
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3458
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> If the query is super large, e.g. contains tens of thousands of nodes or expressions, the RelNode digest and desc become very large. The content of desc and digest are almost the same, except that desc consists of id plus digest, which causes OOM in our production system. So remove desc, just use {{id + digest}} to produce description.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)