You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2017/01/02 02:18:58 UTC

[jira] [Commented] (SUREFIRE-1324) Surefire incorrectly suppresses exceptions when closing resources.

    [ https://issues.apache.org/jira/browse/SUREFIRE-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15792025#comment-15792025 ] 

Hudson commented on SUREFIRE-1324:
----------------------------------

SUCCESS: Integrated in Jenkins build maven-surefire #1664 (See [https://builds.apache.org/job/maven-surefire/1664/])
[SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing (schulte: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=e5a6b9c8d4f514100a01dea2acf1fb059e294968])
* (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java
* (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/util/DependenciesScannerTest.java
* (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java
* (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
* (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
* (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java
* (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
* (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java
* (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java
* (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
* (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java
* (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java
* (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java
* (edit) surefire-api/pom.xml
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java
* (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java
* (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java


> Surefire incorrectly suppresses exceptions when closing resources.
> ------------------------------------------------------------------
>
>                 Key: SUREFIRE-1324
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1324
>             Project: Maven Surefire
>          Issue Type: Bug
>            Reporter: Christian Schulte
>            Assignee: Christian Schulte
>            Priority: Critical
>
> There are various places where exceptions thrown when closing resources are suppressed although they should be handled. Additionally, the {{PrintStream}} class does not throw exceptions but provides a {{checkError}} method to be used instead. This method has not been used after writing to the {{PrintStream}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)