You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/26 07:00:10 UTC
[GitHub] [apisix-ingress-controller] jbampton opened a new pull request #272: chore: fix spelling
jbampton opened a new pull request #272:
URL: https://github.com/apache/apisix-ingress-controller/pull/272
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
___
### Backport patches
- Why need to backport?
- Source branch
- Related commits and pull requests
- Target branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #272: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #272:
URL: https://github.com/apache/apisix-ingress-controller/pull/272#issuecomment-786455635
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr&el=h1) Report
> Merging [#272](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr&el=desc) (23ff6ad) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5a8189024fb90b52f96602501ec3e0eb71dc5fc0?el=desc) (5a81890) will **decrease** coverage by `0.02%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 53.85% 53.83% -0.03%
==========================================
Files 33 32 -1
Lines 2245 2244 -1
==========================================
- Hits 1209 1208 -1
Misses 879 879
Partials 157 157
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `46.24% <0.00%> (ø)` | |
| [pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/version/version.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr&el=tree#diff-cGtnL3ZlcnNpb24vdmVyc2lvbi5nbw==) | `100.00% <ø> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (ø)` | |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr&el=footer). Last update [5a81890...23ff6ad](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #272: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #272:
URL: https://github.com/apache/apisix-ingress-controller/pull/272#issuecomment-786588755
OK,it doesn't matter :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #272: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #272:
URL: https://github.com/apache/apisix-ingress-controller/pull/272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] jbampton commented on pull request #272: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #272:
URL: https://github.com/apache/apisix-ingress-controller/pull/272#issuecomment-786564087
Hey @tokers I used my editor to find these spelling mistakes so we can't add it to the CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #272: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #272:
URL: https://github.com/apache/apisix-ingress-controller/pull/272#issuecomment-786537451
@jbampton Could we add this feature to CI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org