[GitHub] [pulsar] crossoverJie commented on a diff in pull request #18406: [fix][client] Fix possible npe

[GitBox <gi...@apache.org>]

crossoverJie commented on code in PR #18406:
URL: https://github.com/apache/pulsar/pull/18406#discussion_r1018925851


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -1296,6 +1296,9 @@ private void checkRequestTimeout() {
                 break;
             }
             request = requestTimeoutQueue.poll();

Review Comment:
   `remove()` throw aa `NoSuchElementException` when the queue is empty.



##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -1296,6 +1296,9 @@ private void checkRequestTimeout() {
                 break;
             }
             request = requestTimeoutQueue.poll();

Review Comment:
   `remove()` throw a `NoSuchElementException` when the queue is empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org