[GitHub] [flink] azagrebin commented on a change in pull request #8494: [FLINK-12570] Switch Task from ResultPartition to ResultPartitionWriter interface

[GitBox <gi...@apache.org>]

azagrebin commented on a change in pull request #8494: [FLINK-12570] Switch Task from ResultPartition to ResultPartitionWriter interface
URL: https://github.com/apache/flink/pull/8494#discussion_r285990958
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
 ##########
 @@ -65,4 +67,23 @@
 	 * Manually trigger consumption from enqueued {@link BufferConsumer BufferConsumers} in one specified subpartition.
 	 */
 	void flush(int subpartitionIndex);
+
+	/**
+	 * Fails partition producing.
+	 *
+	 * <p>The method propagates non-{@code null} failure cause to consumer based on best effort.
+	 * It may also release some resources.
+	 * Closing of partition is still needed afterwards.
+	 *
+	 * @param throwable failure cause
+	 */
+	void fail(@Nullable Throwable throwable);
+
+	/**
+	 * Indicates successful end of partition producing.
+	 *
+	 * <p>It can be used to notify and release consumer.
 
 Review comment:
   True, deploy in case of blocking and it actually notifies JM which is not shuffle concern but wrapper's in Task.
   For pipelined it looks more like releasing by sending EndOfPartition, I will just change to `notify consumers that the producing is done`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services