[jira] [Created] (ARROW-5828) [C++] Add Protocol Buffers version check

["Sutou Kouhei (JIRA)" <ji...@apache.org>]

Sutou Kouhei created ARROW-5828:
-----------------------------------

             Summary: [C++] Add Protocol Buffers version check
                 Key: ARROW-5828
                 URL: https://issues.apache.org/jira/browse/ARROW-5828
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Sutou Kouhei
            Assignee: Sutou Kouhei
             Fix For: 1.0.0


If we use old Protocol Buffers, bundled gRPC reports build error:

https://lists.apache.org/thread.html/10f8c4d2372638c57c3a956180b2fa3bbd036a27d79eb2eb7b9ffe76@%3Cdev.arrow.apache.org%3E

{noformat}
  /tmp/arrow-0.14.0.dJDu3/apache-arrow-0.14.0/cpp/build/grpc_ep-prefix/src/grpc_ep/src/compiler/php_generator.cc:21:10:
fatal error: google/protobuf/compiler/php/php_generator.h: No such
file or directory
   #include <google/protobuf/compiler/php/php_generator.h>
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.
  make[5]: *** [CMakeFiles/grpc_plugin_support.dir/src/compiler/php_generator.cc.o]
Error 1
  make[5]: *** Waiting for unfinished jobs....
  /tmp/arrow-0.14.0.dJDu3/apache-arrow-0.14.0/cpp/build/grpc_ep-prefix/src/grpc_ep/src/compiler/ruby_generator.cc:
In function ‘grpc::string grpc_ruby_generator::GetServices(const
FileDescriptor*)’:
  /tmp/arrow-0.14.0.dJDu3/apache-arrow-0.14.0/cpp/build/grpc_ep-prefix/src/grpc_ep/src/compiler/ruby_generator.cc:165:25:
error: ‘const class google::protobuf::FileOptions’ has no member named
‘has_ruby_package’; did you mean ‘has_java_package’?
       if (file->options().has_ruby_package()) {
                           ^~~~~~~~~~~~~~~~
                           has_java_package
  /tmp/arrow-0.14.0.dJDu3/apache-arrow-0.14.0/cpp/build/grpc_ep-prefix/src/grpc_ep/src/compiler/ruby_generator.cc:166:38:
error: ‘const class google::protobuf::FileOptions’ has no member named
‘ruby_package’; did you mean ‘java_package’?
         package_name = file->options().ruby_package();
                                        ^~~~~~~~~~~~
                                        java_package
  make[5]: *** [CMakeFiles/grpc_plugin_support.dir/src/compiler/ruby_generator.cc.o]
Error 1
  make[4]: *** [CMakeFiles/grpc_plugin_support.dir/all] Error 2
  make[4]: *** Waiting for unfinished jobs....
  make[3]: *** [all] Error 2
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)