You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/11 13:03:30 UTC
[GitHub] codecov-io commented on issue #1589: add @Override annotation and
clean code.
codecov-io commented on issue #1589: add @Override annotation and clean code.
URL: https://github.com/apache/incubator-dubbo/pull/1589#issuecomment-380443916
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1589?src=pr&el=h1) Report
> Merging [#1589](https://codecov.io/gh/apache/incubator-dubbo/pull/1589?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/d80a42cc69d16d3cb3391ba9f5ec2cc64436839f?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/graphs/tree.svg?src=pr&token=VnEIkiFQT0&width=650&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1589?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1589 +/- ##
============================================
- Coverage 34.56% 34.48% -0.09%
+ Complexity 3688 3681 -7
============================================
Files 621 621
Lines 30875 30874 -1
Branches 5448 5448
============================================
- Hits 10673 10647 -26
- Misses 18367 18386 +19
- Partials 1835 1841 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1589?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...com/alibaba/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1JlZmVyZW5jZUJlYW4uamF2YQ==) | `25.92% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| [...a/com/alibaba/dubbo/config/spring/ServiceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1NlcnZpY2VCZWFuLmphdmE=) | `28.67% <ø> (ø)` | `15 <0> (ø)` | :arrow_down: |
| [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...onfig/spring/schema/DubboBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9EdWJib0JlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `20.74% <ø> (-0.33%)` | `18 <0> (ø)` | |
| [.../config/spring/status/DataSourceStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3N0YXR1cy9EYXRhU291cmNlU3RhdHVzQ2hlY2tlci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../spring/schema/AnnotationBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9Bbm5vdGF0aW9uQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `100% <ø> (ø)` | `5 <0> (ø)` | :arrow_down: |
| [...nnotation/DubboClassPathBeanDefinitionScanner.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvYW5ub3RhdGlvbi9EdWJib0NsYXNzUGF0aEJlYW5EZWZpbml0aW9uU2Nhbm5lci5qYXZh) | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ba/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDbGllbnQuamF2YQ==) | `74.13% <0%> (-8.63%)` | `12% <0%> (-1%)` | |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `61.25% <0%> (-5%)` | `20% <0%> (-1%)` | |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1589/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1589?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1589?src=pr&el=footer). Last update [d80a42c...a142c38](https://codecov.io/gh/apache/incubator-dubbo/pull/1589?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services