You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by Jan Bernhardt <jb...@talend.com> on 2012/10/09 17:28:06 UTC

User Workflow

Hi @all,

I attached a picture [1] of the current workflow structure in syncope (Version 1.0.1-incubating). This could be helpful at your Wiki-Page to visualize a normal User process in syncope. (So feel free to publish this picture).

I also attached a second image [2] showing a modified workflow. This modified workflow allows changing of attributes of suspended users (relied to [4]). I also attached the modified BPMN workflow [3] for this purpose.
After applying this workflow to my syncope instance I've got the effect, that users will be set active after any user updates. The attention was to be able of changing inactive (suspended) user attributes while these users remain inactive. I believe that the root cause for this behavior is that an attribute "enabled" is checked (Line 80, [3]) which is not set at this point. Why is this attribute (enabled) used instead of ${syncopeUser. getSuspended()} ? If the second case would be true, this should solve the current issue and then there would be no need for the AutoActivate serviceTask...

In my opinion it should be possible to change attributes of suspended users by default. So my proposal would be to deliver my modified version with the standard installation of syncope.

I also changed the naming in the workflow whenever possible without effecting the implementation to distinct between user workflows and other (e.g. roles, see [5]). My suggestion would be to move (refactor) all user workflow serviceTasks from "org.apache.syncope.core.workflow.activiti" to "org.apache.syncope.core.workflow.activiti.user". By doing so it will be easier for [5] to add role serviceTasks.

Feedback is highly welcome ;-)

Best regards.
Jan

[1] Workflow2.png
[2] Workflow-new.png
[3] syncopeWorkflow.xml
[4] Syncope User Mailing List - Subject: "Issue with importing suspended user"
[5] https://issues.apache.org/jira/browse/SYNCOPE-173

Jan Bernhardt, M.Sc.
Professional Service Consultant

Talend GmbH | Servatiusstrasse 53 - 53175 Bonn - Germany | +49 228 76 37 76 0 | www.talend.com<http://www.talend.com/>
Global Leader in Open Source Integration


Re: User Workflow

Posted by Francesco Chicchiriccò <il...@apache.org>.
Hi Jan,
attachments got stripped by ML: I'd suggest to open an issue on JIRA and 
attach everything there, text included.

Regards.

On 09/10/2012 17:28, Jan Bernhardt wrote:
>
> Hi @all,
>
> I attached a picture [1] of the current workflow structure in syncope 
> (Version 1.0.1-incubating). This could be helpful at your Wiki-Page to 
> visualize a normal User process in syncope. (So feel free to publish 
> this picture).
>
> I also attached a second image [2] showing a modified workflow. This 
> modified workflow allows changing of attributes of suspended users 
> (relied to [4]). I also attached the modified BPMN workflow [3] for 
> this purpose.
>
> After applying this workflow to my syncope instance I've got the 
> effect, that users will be set active after any user updates. The 
> attention was to be able of changing inactive (suspended) user 
> attributes while these users remain inactive. I believe that the root 
> cause for this behavior is that an attribute "enabled" is checked 
> (Line 80, [3]) which is not set at this point. Why is this attribute 
> (enabled) used instead of ${syncopeUser. getSuspended()} ? If the 
> second case would be true, this should solve the current issue and 
> then there would be no need for the AutoActivate serviceTask...
>
> In my opinion it should be possible to change attributes of suspended 
> users by default. So my proposal would be to deliver my modified 
> version with the standard installation of syncope.
>
> I also changed the naming in the workflow whenever possible without 
> effecting the implementation to distinct between user workflows and 
> other (e.g. roles, see [5]). My suggestion would be to move (refactor) 
> all user workflow serviceTasks from 
> "org.apache.syncope.core.workflow.activiti" to 
> "org.apache.syncope.core.workflow.activiti.user". By doing so it will 
> be easier for [5] to add role serviceTasks.**
>
> Feedback is highly welcome ;-)
>
> Best regards.
>
> Jan
>
> **
>
> [1] Workflow2.png
>
> [2] Workflow-new.png
>
> [3] syncopeWorkflow.xml
>
> [4] Syncope User Mailing List -- Subject: "Issue with importing 
> suspended user"
>
> [5] https://issues.apache.org/jira/browse/SYNCOPE-173
>
> **
>
> *Jan Bernhardt, M.Sc.*
> *Professional Service Consultant*
>
> *Talend* *GmbH *| Servatiusstrasse 53 - 53175 Bonn - Germany | +49 228 
> 76 37 76 0 | www.talend.com <http://www.talend.com/>
> *Global Leader in Open Source Integration*
>


-- 
Francesco Chicchiriccò

ASF Member, Apache Cocoon PMC and Apache Syncope PPMC Member
http://people.apache.org/~ilgrosso/


RE: User Workflow

Posted by Jan Bernhardt <jb...@talend.com>.
That's correct.

Regards.
Jan

-----Original Message-----
From: Francesco Chicchiriccò [mailto:ilgrosso@apache.org] 
Sent: Mittwoch, 10. Oktober 2012 09:23
To: syncope-dev@incubator.apache.org
Subject: Re: User Workflow

On 09/10/2012 17:28, Jan Bernhardt wrote:
>
> Hi @all,
>
> I attached a picture [1] of the current workflow structure in syncope 
> (Version 1.0.1-incubating). This could be helpful at your Wiki-Page to 
> visualize a normal User process in syncope. (So feel free to publish 
> this picture).
>
> I also attached a second image [2] showing a modified workflow. This 
> modified workflow allows changing of attributes of suspended users 
> (relied to [4]). I also attached the modified BPMN workflow [3] for 
> this purpose.
>
> After applying this workflow to my syncope instance I've got the 
> effect, that users will be set active after any user updates. The 
> attention was to be able of changing inactive (suspended) user 
> attributes while these users remain inactive. I believe that the root 
> cause for this behavior is that an attribute "enabled" is checked 
> (Line 80, [3]) which is not set at this point. Why is this attribute
> (enabled) used instead of ${syncopeUser. getSuspended()} ? If the 
> second case would be true, this should solve the current issue and 
> then there would be no need for the AutoActivate serviceTask...
>
> In my opinion it should be possible to change attributes of suspended 
> users by default. So my proposal would be to deliver my modified 
> version with the standard installation of syncope.
>
> I also changed the naming in the workflow whenever possible without 
> effecting the implementation to distinct between user workflows and 
> other (e.g. roles, see [5]). My suggestion would be to move (refactor) 
> all user workflow serviceTasks from 
> "org.apache.syncope.core.workflow.activiti" to 
> "org.apache.syncope.core.workflow.activiti.user". By doing so it will 
> be easier for [5] to add role serviceTasks.**
>
> Feedback is highly welcome ;-)
>

As far as I can see, you've reported the content of this e-mail (including stripped attachments) in SYNCOPE-218 and SYNCOPE-219.

Let's move the discussion to SYNCOPE-219, then.

Regards.

> Best regards.
>
> Jan
>
> **
>
> [1] Workflow2.png
>
> [2] Workflow-new.png
>
> [3] syncopeWorkflow.xml
>
> [4] Syncope User Mailing List -- Subject: "Issue with importing 
> suspended user"
>
> [5] https://issues.apache.org/jira/browse/SYNCOPE-173
>
> **
>
> *Jan Bernhardt, M.Sc.*
> *Professional Service Consultant*
>
> *Talend* *GmbH *| Servatiusstrasse 53 - 53175 Bonn - Germany | +49 228
> 76 37 76 0 | www.talend.com <http://www.talend.com/> *Global Leader in 
> Open Source Integration*
>
--
Francesco Chicchiriccò

ASF Member, Apache Cocoon PMC and Apache Syncope PPMC Member http://people.apache.org/~ilgrosso/


Re: User Workflow

Posted by Francesco Chicchiriccò <il...@apache.org>.
On 09/10/2012 17:28, Jan Bernhardt wrote:
>
> Hi @all,
>
> I attached a picture [1] of the current workflow structure in syncope 
> (Version 1.0.1-incubating). This could be helpful at your Wiki-Page to 
> visualize a normal User process in syncope. (So feel free to publish 
> this picture).
>
> I also attached a second image [2] showing a modified workflow. This 
> modified workflow allows changing of attributes of suspended users 
> (relied to [4]). I also attached the modified BPMN workflow [3] for 
> this purpose.
>
> After applying this workflow to my syncope instance I've got the 
> effect, that users will be set active after any user updates. The 
> attention was to be able of changing inactive (suspended) user 
> attributes while these users remain inactive. I believe that the root 
> cause for this behavior is that an attribute "enabled" is checked 
> (Line 80, [3]) which is not set at this point. Why is this attribute 
> (enabled) used instead of ${syncopeUser. getSuspended()} ? If the 
> second case would be true, this should solve the current issue and 
> then there would be no need for the AutoActivate serviceTask...
>
> In my opinion it should be possible to change attributes of suspended 
> users by default. So my proposal would be to deliver my modified 
> version with the standard installation of syncope.
>
> I also changed the naming in the workflow whenever possible without 
> effecting the implementation to distinct between user workflows and 
> other (e.g. roles, see [5]). My suggestion would be to move (refactor) 
> all user workflow serviceTasks from 
> "org.apache.syncope.core.workflow.activiti" to 
> "org.apache.syncope.core.workflow.activiti.user". By doing so it will 
> be easier for [5] to add role serviceTasks.**
>
> Feedback is highly welcome ;-)
>

As far as I can see, you've reported the content of this e-mail 
(including stripped attachments) in SYNCOPE-218 and SYNCOPE-219.

Let's move the discussion to SYNCOPE-219, then.

Regards.

> Best regards.
>
> Jan
>
> **
>
> [1] Workflow2.png
>
> [2] Workflow-new.png
>
> [3] syncopeWorkflow.xml
>
> [4] Syncope User Mailing List -- Subject: "Issue with importing 
> suspended user"
>
> [5] https://issues.apache.org/jira/browse/SYNCOPE-173
>
> **
>
> *Jan Bernhardt, M.Sc.*
> *Professional Service Consultant*
>
> *Talend* *GmbH *| Servatiusstrasse 53 - 53175 Bonn - Germany | +49 228 
> 76 37 76 0 | www.talend.com <http://www.talend.com/>
> *Global Leader in Open Source Integration*
>
-- 
Francesco Chicchiriccò

ASF Member, Apache Cocoon PMC and Apache Syncope PPMC Member
http://people.apache.org/~ilgrosso/