You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Oleg Ignatenko (JIRA)" <ji...@apache.org> on 2019/01/30 09:12:00 UTC
[jira] [Comment Edited] (IGNITE-10179) Change new tests root to use
@BeforeClass and @AfterClass instead of isFirstTest() and isLastTest()
[ https://issues.apache.org/jira/browse/IGNITE-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755174#comment-16755174 ]
Oleg Ignatenko edited comment on IGNITE-10179 at 1/30/19 9:11 AM:
------------------------------------------------------------------
(i) [~agoncharuk] - this PR ([#5925|https://github.com/apache/ignite/pull/5925]) is one I told you about last week, I would much appreciate if you take a look at it. TC bot visa above suggests that it is most probably correct, however I will repeat this TC run in order to make sure that multiple changes and merges from master made in last few days didn't break something in previously validated test suites.
Core changes worth looking at are in {{GridAbstractTest}} and in {{GridSpiAbstractTest}}, the rest is essentially just a scaffolding made to accommodate these changes. Also of interest may be the expansion made in {{MvccFeatureChecker}} to leverage JUnit 4 Assume API (IGNITE-11123) but in the big picture it probably still qualifies more as a scaffolding.
-----
Special thanks to [~Pavlukhin] for the idea to use class rule. Ivan, you can also take a look at how it is implemented here if you're interested.
-----
(/) update visa obtained after TC re-run (see [comment from bot below|https://issues.apache.org/jira/browse/IGNITE-10179?focusedCommentId=16755866&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16755866]) suggests that this time there were no regressions. At last.
was (Author: oignatenko):
(i) [~agoncharuk] - this PR ([#5925|https://github.com/apache/ignite/pull/5925]) is one I told you about last week, I would much appreciate if you take a look at it. TC bot visa above suggests that it is most probably correct, however I will repeat this TC run in order to make sure that multiple changes and merges from master made in last few days didn't break something in previously validated test suites.
Core changes worth looking at are in {{GridAbstractTest}} and in {{GridSpiAbstractTest}}, the rest is essentially just a scaffolding made to accommodate these changes. Also of interest may be the expansion made in {{MvccFeatureChecker}} to leverage JUnit 4 Assume API (IGNITE-11123) but in the big picture it probably still qualifies more as a scaffolding.
-----
Special thanks to [~Pavlukhin] for the idea to use class rule. Ivan, you can also take a look at how it is implemented here if you're interested.
> Change new tests root to use @BeforeClass and @AfterClass instead of isFirstTest() and isLastTest()
> ---------------------------------------------------------------------------------------------------
>
> Key: IGNITE-10179
> URL: https://issues.apache.org/jira/browse/IGNITE-10179
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Oleg Ignatenko
> Assignee: Oleg Ignatenko
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If needed, refer parent task for more details.
> isFirstTest() and isLastTest() homebrew methods seem to be in GridAbstractTest only because Junit 3 lacked necessary functionality; after migration to Junit 4 these would better changed to use standard API of this framework.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)