You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/30 07:07:25 UTC

[GitHub] [apisix-website] SkyeYoung opened a new pull request, #1173: fix: optimize and remove useless things

SkyeYoung opened a new pull request, #1173:
URL: https://github.com/apache/apisix-website/pull/1173

   Fixes: #[Add issue number here]
   
   Changes:
   
   <!-- Add here what changes were made in this pull request and if possible provide links showcasing the changes. -->
   
   Screenshots of the change:
   
   <!-- Add screenshots depicting the changes. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-website] juzhiyuan merged pull request #1173: fix: optimize and remove useless things

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #1173:
URL: https://github.com/apache/apisix-website/pull/1173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-website] netlify[bot] commented on pull request #1173: fix: optimize and remove useless things

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on PR #1173:
URL: https://github.com/apache/apisix-website/pull/1173#issuecomment-1170848614

   ### <span aria-hidden="true">👷</span> Deploy Preview for *apache-apisix* processing.
   
   
   |  Name | Link |
   |---------------------------------|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 7b16aabd2befc5380b5299387fe836d682e43ca1 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/62bd4bad06c0710009c09e75 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-website] SkyeYoung commented on pull request #1173: fix: optimize and remove useless things

Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on PR #1173:
URL: https://github.com/apache/apisix-website/pull/1173#issuecomment-1171819207

   @1502shivam-singh Thank you! I will start working on this as soon as possible!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-website] 1502shivam-singh commented on pull request #1173: fix: optimize and remove useless things

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on PR #1173:
URL: https://github.com/apache/apisix-website/pull/1173#issuecomment-1171216366

   @SkyeYoung, would appreciate you rework/reset, the hero section animation to previous version, because the current one, animation wise, has terribly off spacing and timing.
   Also, reset the the graphic in hero/top most section on mobile phones (tbh, there is minimal or almost no performance gain from this change)
   Rest I am fine with 👍. Would appreciate you tag me here in case making changes like these.
   
   cc @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-website] 1502shivam-singh commented on pull request #1173: fix: optimize and remove useless things

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on PR #1173:
URL: https://github.com/apache/apisix-website/pull/1173#issuecomment-1171642644

   Oh, okay. Nice initiative from your side. I would have really assisted you on this if I didn't have other work priorities (sad).
   Even so, maybe this will help you. Use the below mentioned code to understand the easing curve type, durations and gaps (stagger) between intermediate animation.
   
   
   ```
       const tl = gsap.timeline({
         defaults: {
           ease: 'Expo.easeInOut',
         },
       });
   
       tl.fromTo([titleRef.current, subtitleRef.current, ctaRef.current], {
         opacity: 0,
         y: 10,
       }, {
         opacity: 1,
         y: 0,
         stagger: 0.3,
       });
   ```
   
   Then, edit this animation that you have defined -
   
   ```
   .hide-title,
   .hide-subtitle,
   .hide-ctas {
     opacity: 0;
   @keyframes fade-in-up {
     from {
       opacity: 0;
       transform: translate3d(0, 50%, 0);
     }
   
     to {
       opacity: 1;
       transform: translate3d(0, 0, 0);
     }
   }
   
   .hero-title,
   .hero-subtitle,
   .hero-ctas {
     animation-name: fade-in-up;
     animation-fill-mode: both;
     animation-delay: 0s;
     animation-duration: 1s;
   }
   
   .
   .
   .
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-website] SkyeYoung commented on pull request #1173: fix: optimize and remove useless things

Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on PR #1173:
URL: https://github.com/apache/apisix-website/pull/1173#issuecomment-1171292397

   @1502shivam-singh I'm working on that. The reason for this is that the original animation would have to show a lot of blanks on the first load due to the loading speed of GSAP in poor network conditions. So I'm using CSS animations to mimic the original animations (the text part) as much as possible, but I don't have enough time to tweak it enough.
   The mobile part is also being tweaked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org