You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/11/08 11:09:46 UTC

DO NOT REPLY [Bug 50232] New: org.apache.catalina.session.StoreBase has a hidden dependency on PersistentManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=50232

           Summary: org.apache.catalina.session.StoreBase has a hidden
                    dependency on PersistentManager
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: tsbatista@ua.pt


Created an attachment (id=26270)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26270)
Removes hidden dependency on PersistentStore

StoreBase.java depends explicitly on the Manager interface, however, it later
casts the manager object to the PersistentManager class with out any check.

This removes that dependency, therefore allowing the usage of this store with
any manager that does not extend PersistentManager.

I will later attach a path that removes the offending isLoaded() method as that
may induce the same problem further along...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 50232] org.apache.catalina.session.StoreBase has a hidden dependency on PersistentManager

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50232

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> 2010-11-09 10:32:48 EST ---
Thanks for the patches. Fixed in trunk (with a slight modification) and will be
included in 7.0.5 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 50232] org.apache.catalina.session.StoreBase has a hidden dependency on PersistentManager

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50232

--- Comment #1 from Tiago Batista <ts...@ua.pt> 2010-11-08 05:19:24 EST ---
Created an attachment (id=26271)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26271)
Removes the isLoaded method from PersistentManagerBase

This patch removes the isLoaded method that was previously called only by
StoreBase. This is optional, but as that particular path of code is no longer
used, it seemed like the right thing to do.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org