[GitHub] [pulsar-client-python] erichare commented on a diff in pull request #90: [fix] exception bug as per #89

["erichare (via GitHub)" <gi...@apache.org>]

erichare commented on code in PR #90:
URL: https://github.com/apache/pulsar-client-python/pull/90#discussion_r1093821836


##########
pulsar/schema/schema_avro.py:
##########
@@ -82,15 +82,6 @@ def decode(self, data):
                 return self._record_cls(**d)
             else:
                 return d
-
 else:
-    class AvroSchema(Schema):
-        def __init__(self, _record_cls, _schema_definition=None):
-            raise Exception("Avro library support was not found. Make sure to install Pulsar client " +
+    raise Exception("Avro library support was not found. Make sure to install Pulsar client " +

Review Comment:
   The bug is an interesting finding... but yeah, right now AvroSchema gets imported in various places, and attempting to do so without fastavro installed (and importable) will lead to this exception being raised, when really it should only be raised when attempting to initialize a  new AvroSchema. So i don't think this should be merged in as is.
   
   With that said, why you're experiencing the bug that you are @keenborder786 , no clue when it comes to that yet...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org