You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "FelipeGLopez (via GitHub)" <gi...@apache.org> on 2025/12/01 16:23:59 UTC
[PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
FelipeGLopez opened a new pull request, #36359:
URL: https://github.com/apache/superset/pull/36359
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Refresh the Query History data immediately after a query finishes running so new entries appear without requiring a page reload.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
**Before:**
After running a query and navigating to the Query History tab, the most recent runs did not appear in the correct order (most recent should be at the top). After refreshing the page (second 22 in video), they were ordered correctly:
https://github.com/user-attachments/assets/88e73df7-ef1d-4b3c-b2b0-7a31786d3674
**After:**
Most recent queries are shown at the top of Query History without the need to refresh the page.
https://github.com/user-attachments/assets/da353ec8-8f91-4ce7-88bd-dce0c55cbd18
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Open a new tab in SQL Lab.
2. Run a query.
3. Switch to the Query History tab in SQL Lab (next to Results).
4. Verify that the query history is ordered by the most recent entries (sorted by datetime).
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [X] Required feature flags: `ENABLE_TEMPLATE_PROCESSING`
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36359:
URL: https://github.com/apache/superset/pull/36359#issuecomment-3604163288
Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following:
```
pip3 install -r requirements/development.txt
pre-commit install
```
A series of checks will now run when you make a git commit.
Alternatively it is possible to run pre-commit by running pre-commit manually:
```
pre-commit run --all-files
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36359:
URL: https://github.com/apache/superset/pull/36359#issuecomment-3602201987
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/19861037017) for [56a6936](https://github.com/apache/superset/commit/56a6936)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36359:
URL: https://github.com/apache/superset/pull/36359#issuecomment-3607113271
CodeAnt AI finished reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev merged PR #36359:
URL: https://github.com/apache/superset/pull/36359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36359:
URL: https://github.com/apache/superset/pull/36359#issuecomment-3607113063
## Nitpicks 🔍
<table>
<tr><td>🔒 <strong>No security issues identified</strong></td></tr>
<tr><td>⚡ <strong>Recommended areas for review</strong><br><br>
- [ ] <a href='https://github.com/apache/superset/pull/36359/files#diff-1945a2c286811d95a0d624378f0c0166482175ac35b2fece13a5d1ff792a2c5aR94-R98'><strong>Incorrect sort order</strong></a><br>The new comparator sorts by (aTime - bTime) which produces ascending order (oldest first). The PR's intent is to show the most recent queries at the top (descending). Verify and fix the comparator to ensure newest queries appear first.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36359/files#diff-1945a2c286811d95a0d624378f0c0166482175ac35b2fece13a5d1ff792a2c5aR95-R97'><strong>startDttm type handling</strong></a><br>The code assumes `startDttm` can be used directly in numeric subtraction and falls back to 0. If `startDttm` is an ISO string or another non-numeric type this can lead to incorrect sorting (NaN) or misordered null/undefined values. Ensure `startDttm` is normalized to a numeric timestamp before sorting.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36359/files#diff-8f485cd5ae53e1005fb1bcc12452644710bec6ccbbaa80f77a4547ce92258487R138-R244'><strong>Mock leakage between tests</strong></a><br>The feature-flag mock implementation is set per-test but only cleared with mockClear(), which resets call history but leaves the implementation. That can leak behavior across tests; prefer mockReset()/mockRestore() or a shared afterEach cleanup.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36359/files#diff-8f485cd5ae53e1005fb1bcc12452644710bec6ccbbaa80f77a4547ce92258487R211-R216'><strong>Broad fetch mock route</strong></a><br>The fetchMock route `glob:*/api/v1/query/?q=*` is very broad and may match unrelated requests in larger test suites. Narrow the route or assert on the request query parameters to avoid false positives.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36359/files#diff-8f485cd5ae53e1005fb1bcc12452644710bec6ccbbaa80f77a4547ce92258487R219-R241'><strong>Flaky test selection</strong></a><br>The test uses global text queries (e.g. getByText('443') / getAllByText('1')) which can match other elements and cause flakiness. Assertions should target specific table rows/cells to assert ordering deterministically.<br>
</td></tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36359:
URL: https://github.com/apache/superset/pull/36359#issuecomment-3607098394
CodeAnt AI is reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36359:
URL: https://github.com/apache/superset/pull/36359#issuecomment-3597496187
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #36359:
URL: https://github.com/apache/superset/pull/36359#discussion_r2585327193
##########
superset-frontend/src/SqlLab/components/QueryHistory/QueryHistory.test.tsx:
##########
@@ -133,3 +133,112 @@ test('fetches the query history by the tabViewId', async () => {
expect(queryResultText).toBeInTheDocument();
isFeatureEnabledMock.mockClear();
});
+
+test('displays multiple queries with newest query first', async () => {
+ const isFeatureEnabledMock = mockedIsFeatureEnabled.mockImplementation(
+ featureFlag => featureFlag === FeatureFlag.SqllabBackendPersistence,
+ );
+
+ const multipleQueriesApiResult = {
+ count: 2,
+ ids: [694, 693],
+ result: [
+ {
+ changed_on: '2024-03-12T20:10:02.497775',
+ client_id: 'd2ZDzRYzn',
+ database: {
+ database_name: 'examples',
+ id: 1,
+ },
+ end_time: '1710274202496.047852',
+ error_message: null,
+ executed_sql: 'SELECT COUNT(*) from "FCC 2018 Survey"\nLIMIT 1001',
+ id: 694,
+ limit: 1000,
+ limiting_factor: 'DROPDOWN',
+ progress: 100,
+ results_key: null,
+ rows: 1,
+ schema: 'main',
+ select_as_cta: false,
+ sql: 'SELECT COUNT(*) from "FCC 2018 Survey"',
+ sql_editor_id: '22',
+ start_time: '1710274202445.992920',
+ status: QueryState.Success,
+ tab_name: 'Untitled Query 2',
+ tmp_table_name: null,
+ tracking_url: null,
+ user: {
+ first_name: 'admin',
+ id: 1,
+ last_name: 'user',
+ },
+ },
+ {
+ changed_on: '2024-03-12T20:01:02.497775',
+ client_id: 'b0ZDzRYzn',
+ database: {
+ database_name: 'examples',
+ id: 1,
+ },
+ end_time: '1710273662496.047852',
+ error_message: null,
+ executed_sql: 'SELECT * from "FCC 2018 Survey"\nLIMIT 1001',
+ id: 693,
+ limit: 1000,
+ limiting_factor: 'DROPDOWN',
+ progress: 100,
+ results_key: null,
+ rows: 443,
+ schema: 'main',
+ select_as_cta: false,
+ sql: 'SELECT * from "FCC 2018 Survey"',
+ sql_editor_id: '22',
+ start_time: '1710273662445.992920',
+ status: QueryState.Success,
+ tab_name: 'Untitled Query 1',
+ tmp_table_name: null,
+ tracking_url: null,
+ user: {
+ first_name: 'admin',
+ id: 1,
+ last_name: 'user',
+ },
+ },
+ ],
+ };
+
+ const editorQueryApiRoute = `glob:*/api/v1/query/?q=*`;
+ fetchMock.get(editorQueryApiRoute, multipleQueriesApiResult);
+ const { container } = render(setup(), { useRedux: true, initialState });
+
+ await waitFor(() =>
+ expect(fetchMock.calls(editorQueryApiRoute).length).toBe(1),
+ );
+
+ expect(screen.getByTestId('listview-table')).toBeVisible();
+ expect(screen.getByRole('table')).toBeVisible();
+
+ const tableRows = container.querySelectorAll(
+ 'table > tbody > tr:not(.ant-table-measure-row)',
+ );
+ expect(tableRows).toHaveLength(2);
+
+ // Check that both queries are present
+ const olderQueryRow = screen.getByText('443');
+ const newerQueryElements = screen.getAllByText('1');
+ expect(olderQueryRow).toBeInTheDocument();
+ expect(newerQueryElements.length).toBeGreaterThan(0);
Review Comment:
**Suggestion:** Using `screen.getAllByText('1')` is fragile and can match other '1' occurrences in the DOM (headers, timestamps, ids), causing flakiness; instead, explicitly search the table rows (which you already query) to assert that at least one data row contains the expected '1' value. [possible bug]
**Severity Level:** Critical 🚨
```suggestion
const hasNewerQuery = Array.from(
container.querySelectorAll('table > tbody > tr:not(.ant-table-measure-row)'),
).some(row => row.textContent?.includes('1'));
expect(olderQueryRow).toBeInTheDocument();
expect(hasNewerQuery).toBe(true);
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
This is a useful and practical improvement. Using getAllByText('1') is brittle because small numeric strings often appear elsewhere (headers, timestamps). Scoping the assertion to the queried table rows (which the test already selects) makes the check more robust and directly verifies the rendered data. The improved_code correctly uses the rendered container to assert presence within the table rows.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/SqlLab/components/QueryHistory/QueryHistory.test.tsx
**Line:** 229:231
**Comment:**
*Possible Bug: Using `screen.getAllByText('1')` is fragile and can match other '1' occurrences in the DOM (headers, timestamps, ids), causing flakiness; instead, explicitly search the table rows (which you already query) to assert that at least one data row contains the expected '1' value.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
##########
superset-frontend/src/SqlLab/components/QueryHistory/QueryHistory.test.tsx:
##########
@@ -133,3 +133,112 @@ test('fetches the query history by the tabViewId', async () => {
expect(queryResultText).toBeInTheDocument();
isFeatureEnabledMock.mockClear();
});
+
+test('displays multiple queries with newest query first', async () => {
+ const isFeatureEnabledMock = mockedIsFeatureEnabled.mockImplementation(
+ featureFlag => featureFlag === FeatureFlag.SqllabBackendPersistence,
+ );
+
+ const multipleQueriesApiResult = {
+ count: 2,
+ ids: [694, 693],
+ result: [
+ {
+ changed_on: '2024-03-12T20:10:02.497775',
+ client_id: 'd2ZDzRYzn',
+ database: {
+ database_name: 'examples',
+ id: 1,
+ },
+ end_time: '1710274202496.047852',
+ error_message: null,
+ executed_sql: 'SELECT COUNT(*) from "FCC 2018 Survey"\nLIMIT 1001',
+ id: 694,
+ limit: 1000,
+ limiting_factor: 'DROPDOWN',
+ progress: 100,
+ results_key: null,
+ rows: 1,
+ schema: 'main',
+ select_as_cta: false,
+ sql: 'SELECT COUNT(*) from "FCC 2018 Survey"',
+ sql_editor_id: '22',
+ start_time: '1710274202445.992920',
+ status: QueryState.Success,
+ tab_name: 'Untitled Query 2',
+ tmp_table_name: null,
+ tracking_url: null,
+ user: {
+ first_name: 'admin',
+ id: 1,
+ last_name: 'user',
+ },
+ },
+ {
+ changed_on: '2024-03-12T20:01:02.497775',
+ client_id: 'b0ZDzRYzn',
+ database: {
+ database_name: 'examples',
+ id: 1,
+ },
+ end_time: '1710273662496.047852',
+ error_message: null,
+ executed_sql: 'SELECT * from "FCC 2018 Survey"\nLIMIT 1001',
+ id: 693,
+ limit: 1000,
+ limiting_factor: 'DROPDOWN',
+ progress: 100,
+ results_key: null,
+ rows: 443,
+ schema: 'main',
+ select_as_cta: false,
+ sql: 'SELECT * from "FCC 2018 Survey"',
+ sql_editor_id: '22',
+ start_time: '1710273662445.992920',
+ status: QueryState.Success,
+ tab_name: 'Untitled Query 1',
+ tmp_table_name: null,
+ tracking_url: null,
+ user: {
+ first_name: 'admin',
+ id: 1,
+ last_name: 'user',
+ },
+ },
+ ],
+ };
+
+ const editorQueryApiRoute = `glob:*/api/v1/query/?q=*`;
+ fetchMock.get(editorQueryApiRoute, multipleQueriesApiResult);
+ const { container } = render(setup(), { useRedux: true, initialState });
+
+ await waitFor(() =>
+ expect(fetchMock.calls(editorQueryApiRoute).length).toBe(1),
+ );
+
+ expect(screen.getByTestId('listview-table')).toBeVisible();
+ expect(screen.getByRole('table')).toBeVisible();
+
+ const tableRows = container.querySelectorAll(
+ 'table > tbody > tr:not(.ant-table-measure-row)',
+ );
+ expect(tableRows).toHaveLength(2);
+
+ // Check that both queries are present
+ const olderQueryRow = screen.getByText('443');
+ const newerQueryElements = screen.getAllByText('1');
+ expect(olderQueryRow).toBeInTheDocument();
+ expect(newerQueryElements.length).toBeGreaterThan(0);
+
+ // Verify ordering: newer query (1 row) should appear before older query (443 rows)
+ // Find the actual row elements to check their order
+ const firstDataRow = tableRows[0];
+ const secondDataRow = tableRows[1];
+
+ // The newer query should be in the first row (has 1 result row)
+ expect(firstDataRow).toHaveTextContent('1');
+ // The older query should be in the second row (has 443 result rows)
+ expect(secondDataRow).toHaveTextContent('443');
+
+ isFeatureEnabledMock.mockClear();
Review Comment:
**Suggestion:** Using `mockClear()` only clears call history but does not remove the mock implementation; this can leave `isFeatureEnabled` returning the mocked value in subsequent tests and cause test leakage. Replace the single-line cleanup with a call that resets the mock implementation (for example `mockReset()` on the original mock) so the mock state is fully cleared between tests. [possible bug]
**Severity Level:** Critical 🚨
```suggestion
mockedIsFeatureEnabled.mockReset();
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
This suggestion is valid: mockClear() only clears call history and keeps the mock implementation, which can cause test leakage if any test relies on the default/unmocked behavior. Using mockReset() (or mockRestore()/jest.resetAllMocks() in a shared afterEach) will clear both history and implementation making tests more isolated. The suggested improved_code (calling mockReset on the underlying jest mock) is appropriate.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/SqlLab/components/QueryHistory/QueryHistory.test.tsx
**Line:** 243:243
**Comment:**
*Possible Bug: Using `mockClear()` only clears call history but does not remove the mock implementation; this can leave `isFeatureEnabled` returning the mocked value in subsequent tests and cause test leakage. Replace the single-line cleanup with a call that resets the mock implementation (for example `mockReset()` on the original mock) so the mock state is fully cleared between tests.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
##########
superset-frontend/src/SqlLab/components/QueryHistory/index.tsx:
##########
@@ -91,7 +91,11 @@ const QueryHistory = ({
editorId,
)
.concat(data.result)
- .reverse()
+ .sort((a, b) => {
+ const aTime = a.startDttm || 0;
+ const bTime = b.startDttm || 0;
+ return aTime - bTime;
Review Comment:
**Suggestion:** Sorting direction is reversed: the comparator returns aTime - bTime which orders oldest-first; to show most recent queries at the top the comparator must return bTime - aTime (descending order). [logic error]
**Severity Level:** Minor ⚠️
```suggestion
return bTime - aTime;
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
The current comparator orders oldest-first (ascending). For a query history UI you almost always want most-recent-first. Reversing the subtraction to `bTime - aTime` fixes the ordering logic. This is a direct logic correction to the visible bug in this hunk and doesn't require broader changes.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/SqlLab/components/QueryHistory/index.tsx
**Line:** 97:97
**Comment:**
*Logic Error: Sorting direction is reversed: the comparator returns aTime - bTime which orders oldest-first; to show most recent queries at the top the comparator must return bTime - aTime (descending order).
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36359:
URL: https://github.com/apache/superset/pull/36359#issuecomment-3602241627
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/19861037017) for [56a6936](https://github.com/apache/superset/commit/56a6936)
• **Environment:** http://52.13.18.242:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(SQLLab): most recent queries at the top in Query History without refreshing the page [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on PR #36359:
URL: https://github.com/apache/superset/pull/36359#issuecomment-3602275236
Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following:
```
pip3 install -r requirements/development.txt
pre-commit install
```
A series of checks will now run when you make a git commit.
Alternatively it is possible to run pre-commit by running pre-commit manually:
`pre-commit run --all-files`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org