You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by Philippe Mouawad <ph...@gmail.com> on 2016/03/09 23:21:07 UTC

Drop XML Assertion or at least drop JDOM Dependency

Hello,
XML assertion only checks that response is well-formed
XML by parsing the file using JDom 1.X which is now deprecated.

I personally don't find it very useful and have never used it.
So I would tend to drop it.

But if we decide to keep it, then at least we should drop jdom dependency
by just using a javax SAXParser instead
of:http://www.jdom.org/docs/apidocs.1.1/org/jdom/input/SAXBuilder.html


I have attached the patch dropping jdom.

If you are OK, I will commit it.

See:
https://bz.apache.org/bugzilla/show_bug.cgi?id=59156

Thanks

Regards

Re: Drop XML Assertion or at least drop JDOM Dependency

Posted by Philippe Mouawad <ph...@gmail.com>.

Hello,
I dropped JDOM  within https://bz.apache.org/bugzilla/show_bug.cgi?id=59156

I asked a question on user mailing list.
Regards


On Thu, Mar 10, 2016 at 12:30 AM, sebb <se...@gmail.com> wrote:

> On 9 March 2016 at 22:21, Philippe Mouawad <ph...@gmail.com>
> wrote:
> > Hello,
> > XML assertion only checks that response is well-formed
> > XML by parsing the file using JDom 1.X which is now deprecated.
> >
> > I personally don't find it very useful and have never used it.
> > So I would tend to drop it.
>
> I've not used it either.
>
> I suggest we ask on the user list in case there is a genuine use-case.
> Could also ask about the XML Schema Assertion.
>
> If someone wants to validate the file they can save it, or even use the
> > But if we decide to keep it, then at least we should drop jdom dependency
> > by just using a javax SAXParser instead
> > of:http://www.jdom.org/docs/apidocs.1.1/org/jdom/input/SAXBuilder.html
>
> No point if we deprecate now.
>
> >
> > I have attached the patch dropping jdom.
> >
> > If you are OK, I will commit it.
> >
> > See:
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=59156
> >
> > Thanks
> >
> > Regards
>



-- 
Cordialement.
Philippe Mouawad.

Re: Drop XML Assertion or at least drop JDOM Dependency

Posted by sebb <se...@gmail.com>.

On 9 March 2016 at 22:21, Philippe Mouawad <ph...@gmail.com> wrote:
> Hello,
> XML assertion only checks that response is well-formed
> XML by parsing the file using JDom 1.X which is now deprecated.
>
> I personally don't find it very useful and have never used it.
> So I would tend to drop it.

I've not used it either.

I suggest we ask on the user list in case there is a genuine use-case.
Could also ask about the XML Schema Assertion.

If someone wants to validate the file they can save it, or even use the
> But if we decide to keep it, then at least we should drop jdom dependency
> by just using a javax SAXParser instead
> of:http://www.jdom.org/docs/apidocs.1.1/org/jdom/input/SAXBuilder.html

No point if we deprecate now.

>
> I have attached the patch dropping jdom.
>
> If you are OK, I will commit it.
>
> See:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=59156
>
> Thanks
>
> Regards