You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/27 15:02:13 UTC
[kudu-CR](branch-1.7.x) build-and-test.sh: unbreak Python 2.6 based builds
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10228
Change subject: build-and-test.sh: unbreak Python 2.6 based builds
......................................................................
build-and-test.sh: unbreak Python 2.6 based builds
The first beta of pip 10 was released several days ago, and it officially
drops support for Python 2.6, going so far as to use syntax that isn't
recognized by Python 2.6 interpreters. Let's address this by pinning to a
specific version of pip when upgrading (which, frankly, we should have done
a long time ago).
Note: pip supports environmental markers in version specifiers which we
could use to narrow this pinning such that it only takes effect if we're on
Python 2.6. However, the version of pip typically found in older distros is
old enough that it doesn't support environmental markers, so we'd need to do
two pip upgrades: the first to land on a version of pip that supports
markers, and the second to use the markers to conditionally upgrade to the
latest pip. This didn't seem worth the hassle.
Change-Id: I1afb5ba8169d193f502d3733fd3f826e9cb4ce6e
Reviewed-on: http://gerrit.cloudera.org:8080/9936
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
(cherry picked from commit 3d734055c2d9184fed3597dc7e08eed72c9a7ec7)
---
M build-support/jenkins/build-and-test.sh
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/10228/1
--
To view, visit http://gerrit.cloudera.org:8080/10228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1afb5ba8169d193f502d3733fd3f826e9cb4ce6e
Gerrit-Change-Number: 10228
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR](branch-1.7.x) build-and-test.sh: unbreak Python 2.6 based builds
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10228 )
Change subject: build-and-test.sh: unbreak Python 2.6 based builds
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1afb5ba8169d193f502d3733fd3f826e9cb4ce6e
Gerrit-Change-Number: 10228
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 27 Apr 2018 16:25:50 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) build-and-test.sh: unbreak Python 2.6 based builds
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10228 )
Change subject: build-and-test.sh: unbreak Python 2.6 based builds
......................................................................
build-and-test.sh: unbreak Python 2.6 based builds
The first beta of pip 10 was released several days ago, and it officially
drops support for Python 2.6, going so far as to use syntax that isn't
recognized by Python 2.6 interpreters. Let's address this by pinning to a
specific version of pip when upgrading (which, frankly, we should have done
a long time ago).
Note: pip supports environmental markers in version specifiers which we
could use to narrow this pinning such that it only takes effect if we're on
Python 2.6. However, the version of pip typically found in older distros is
old enough that it doesn't support environmental markers, so we'd need to do
two pip upgrades: the first to land on a version of pip that supports
markers, and the second to use the markers to conditionally upgrade to the
latest pip. This didn't seem worth the hassle.
Change-Id: I1afb5ba8169d193f502d3733fd3f826e9cb4ce6e
Reviewed-on: http://gerrit.cloudera.org:8080/9936
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
(cherry picked from commit 3d734055c2d9184fed3597dc7e08eed72c9a7ec7)
Reviewed-on: http://gerrit.cloudera.org:8080/10228
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1afb5ba8169d193f502d3733fd3f826e9cb4ce6e
Gerrit-Change-Number: 10228
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins