You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Dominik Süß (Jira)" <ji...@apache.org> on 2021/07/12 12:13:00 UTC
[jira] [Commented] (JCRVLT-543) DocViewSAXImporter failing on
protected properties for new Nodes
[ https://issues.apache.org/jira/browse/JCRVLT-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379163#comment-17379163 ]
Dominik Süß commented on JCRVLT-543:
------------------------------------
I'm still checking the exact conditions to create a dervied issue. Something seems to be off with this as I currently get
{code}
*ERROR* [OsgiInstallerImpl] com.adobe.granite.installer.factory.packages.impl.PackageTransformer Error while processing install task of adobe/granite:com.adobe.granite.contexthub.content:1.2.2.
org.apache.jackrabbit.vault.packaging.PackageException: javax.jcr.RepositoryException: Some errors occurred while installing packages. Please check the logs for details. First exception is logged as cause.
at org.apache.jackrabbit.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:282) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:397) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:356) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:342) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at com.adobe.granite.installer.factory.packages.impl.PackageTransformer$InstallPackageTask.execute(PackageTransformer.java:346) [com.adobe.granite.installer.factory.packages:1.0.18]
at org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:918)
at org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:755)
at org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:304)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: javax.jcr.RepositoryException: Some errors occurred while installing packages. Please check the logs for details. First exception is logged as cause.
at org.apache.jackrabbit.vault.fs.io.Importer.run(Importer.java:508) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at org.apache.jackrabbit.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:277) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
... 8 common frames omitted
Caused by: javax.jcr.nodetype.ConstraintViolationException: Item is protected.
at org.apache.jackrabbit.oak.jcr.session.ItemImpl$ItemWriteOperation.checkPreconditions(ItemImpl.java:98) [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
at org.apache.jackrabbit.oak.jcr.session.PropertyImpl$4.checkPreconditions(PropertyImpl.java:116) [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.prePerform(SessionDelegate.java:629) [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.performVoid(SessionDelegate.java:272) [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
at org.apache.jackrabbit.oak.jcr.session.PropertyImpl.remove(PropertyImpl.java:113) [org.apache.jackrabbit.oak-jcr:1.39.0.R1889746]
at org.apache.jackrabbit.vault.util.DocViewProperty.apply(DocViewProperty.java:472) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at org.apache.jackrabbit.vault.fs.impl.io.DocViewSAXImporter.setUnprotectedProperties(DocViewSAXImporter.java:1167) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at org.apache.jackrabbit.vault.fs.impl.io.DocViewSAXImporter.createNewNode(DocViewSAXImporter.java:1084) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at org.apache.jackrabbit.vault.fs.impl.io.DocViewSAXImporter.addNode(DocViewSAXImporter.java:903) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at org.apache.jackrabbit.vault.fs.impl.io.DocViewSAXImporter.startElement(DocViewSAXImporter.java:687) [org.apache.jackrabbit.vault:3.5.1.SNAPSHOT]
at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:510)
{code}
noticable that this is being invoked in
https://github.com/apache/jackrabbit-filevault/blob/c612dda36895d379ec57f6d2834158ea513f2967/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1167
where the protected property jcr:mixinTypes should cause be ignored afaict.
> DocViewSAXImporter failing on protected properties for new Nodes
> ----------------------------------------------------------------
>
> Key: JCRVLT-543
> URL: https://issues.apache.org/jira/browse/JCRVLT-543
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
> Affects Versions: 3.5.0
> Reporter: Dominik Süß
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: 3.5.2
>
>
> Starting with https://github.com/apache/jackrabbit-filevault/commit/5f3b1d363da7bcf3c285a0bdbb394254ca3e57d1#diff-96c973bf61e1d3ae0fde08f6c35da64d983623ac50ce2f6af682828d4963a7dbR1166 the behavior for relaxed handling of protected properties is no longer working on newly created nodes. New nodes do not pass a VersioningState causing the Exception to be rethrown at *https://github.com/apache/jackrabbit-filevault/blob/2381d35b1ba4eb2785f3d632b8501983899ce980/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1166*
> This specifically affects System generated properties in case of packages that got generated by building a package from a System.
> // cc [~kwin] as commiter of patch introducing the regeression
--
This message was sent by Atlassian Jira
(v8.3.4#803005)