[jira] Updated: (CASSANDRA-631) possible NPE in StorageProxy?

["gabriele renzi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

gabriele renzi updated CASSANDRA-631:
-------------------------------------

    Attachment: CASSANDRA-631-big.patch
                CASSANDRA-631-tiny.patch

changes the hunhinted ->hinted as per summary. 

The -tiny patch only does that change .

The -big patch also removes other compile warnings from the file (generics, synthetic accessors) and avoids using useless allocations (Collections.max(Arrays.AsList(new ary[a,b])) seems unnecessary when there is only the need to compare two objects and commons-lang already provides a good enough method)

> possible NPE in StorageProxy?
> -----------------------------
>
>                 Key: CASSANDRA-631
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-631
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.5
>         Environment: all
>            Reporter: gabriele renzi
>         Attachments: CASSANDRA-631-big.patch, CASSANDRA-631-tiny.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> insert() in StorageProxy contains a logging statement that refers to a possibly un-initialized variable
> {{{
> logger.debug("insert writing key " + rm.key() + " to " + unhintedMessage.getMessageId() + "@" + hintedTarget + " for " + target);
> }}}
> this could happen if getHintedEndpointMap(rm.key(), naturalEndpoints) returns only elements for which target.equals(hintedTarget) returns false, which seems possible to me. 
> Looking at the code I get the feeling the reference should probably be to 'hintedMessage', instead of "unhintedMessage", if not so an 
> assert statement could be appropriate

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.