You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/26 19:00:10 UTC

[GitHub] GabeLoins opened a new pull request #4482: [Explore] Chart style options get their own tab

GabeLoins opened a new pull request #4482: [Explore] Chart style options get their own tab
URL: https://github.com/apache/incubator-superset/pull/4482
 
 
   ![image](https://user-images.githubusercontent.com/2455694/36689310-e7c6fc94-1ae3-11e8-85dc-e507df25abe2.png)
   
   and then
   
   ![image](https://user-images.githubusercontent.com/2455694/36689327-f017ae3e-1ae3-11e8-93ff-3056953193a8.png)
   
   This way we can keep style configurations out of the way of data configurations, while also making it easier to see all the style configurations in one place!
   
   Open questions: what should the names of these tabs be?
   
   test plan:
   - go to line chart, bar chart and pie cahrt
   - verify style and data configurations are in the correct spots
   - verify style configurations are all expanded by default now that they get their own tab
   
   reviewers:
   @michellethomas @mistercrunch @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services