You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/06/28 21:30:45 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #6792: Use checked division kernel
tustvold opened a new pull request, #6792:
URL: https://github.com/apache/arrow-datafusion/pull/6792
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #6791
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The current behaviour is inconsistent, can lead to nulls in non-nullable columns, and is pretty surprising.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6792: Use checked division kernel
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6792:
URL: https://github.com/apache/arrow-datafusion/pull/6792#discussion_r1245944623
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1670,9 +1670,12 @@ mod tests {
fn test_simplify_divide_zero_by_zero() {
// 0 / 0 -> null
let expr = lit(0) / lit(0);
- let expected = lit(ScalarValue::Int32(None));
+ let err = try_simplify(expr).unwrap_err();
- assert_eq!(simplify(expr), expected);
+ assert!(
Review Comment:
This is consistent with postgres 👍
```sql
postgres=# select 0 / 0;
ERROR: division by zero
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #6792: Use checked division kernel
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #6792:
URL: https://github.com/apache/arrow-datafusion/pull/6792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6792: Use checked division kernel
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6792:
URL: https://github.com/apache/arrow-datafusion/pull/6792#issuecomment-1612262487
cc @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya commented on pull request #6792: Use checked division kernel
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #6792:
URL: https://github.com/apache/arrow-datafusion/pull/6792#issuecomment-1612360780
Hmm, it is inconsistent. We should fix it. But we will prefer default behavior is to get null instead of query error. That is story of Spark but I agree DataFusion doesn't necessarily to follow it at all.
> ... nulls in non-nullable columns, and is pretty surprising.
Is it an issue? In Spark, Divide expression output is nullable always. I think producing null from non-nullable input columns is totally fine if it follows the expression's output type definition.
So the issue is more about inconsistency.
Looks okay to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org