You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/09 11:32:58 UTC

[GitHub] [camel] ahus1 opened a new pull request #3987: [CAMEL-15285] fix broken anchors and images

ahus1 opened a new pull request #3987:
URL: https://github.com/apache/camel/pull/3987


   This PR fixes some broken anchors with in valid characters and a broken image.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd commented on pull request #3987: [CAMEL-15285] fix broken anchors and images

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #3987:
URL: https://github.com/apache/camel/pull/3987#issuecomment-656124890


   > > You need to fix this stuff into the src/main/docs of the single components and then run the build, the src/generated stuff depend from the src/main/docs files.
   > 
   > @oscerd - I double checked and for all generated files both the source and the generated file have been updated in the commits. Did you spot a file that I missed?
   > 
   > I looked at the docs and didn't find a minimal command to just build the documentation. The `gulpfile.js` in the `docs` folder does some of it, but not all. I'd be happy for some advice.
   
   My fault, I've taken a look only at the beginning of the files list. Sorry. There is no command to build the docs directly. You need to build the project completely once, then you could edit the .adoc file on single components, run a component build and then come back to docs folder and run a build, the docs will be updated in that way


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd commented on pull request #3987: [CAMEL-15285] fix broken anchors and images

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #3987:
URL: https://github.com/apache/camel/pull/3987#issuecomment-656138791


   Thanks a lot and sorry for the wrong review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] ahus1 commented on pull request #3987: [CAMEL-15285] fix broken anchors and images

Posted by GitBox <gi...@apache.org>.
ahus1 commented on pull request #3987:
URL: https://github.com/apache/camel/pull/3987#issuecomment-656122235


   > You need to fix this stuff into the src/main/docs of the single components and then run the build, the src/generated stuff depend from the src/main/docs files.
   
   @oscerd - I double checked and for all generated files both the source and the generated file have been updated in the commits. Did you spot a file that I missed? 
   
   I looked at the docs and didn't find a minimal command to just build the documentation. The `gulpfile.js` in the `docs` folder does some of it, but not all. I'd be happy for some advice.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] ahus1 commented on pull request #3987: [CAMEL-15285] fix broken anchors and images

Posted by GitBox <gi...@apache.org>.
ahus1 commented on pull request #3987:
URL: https://github.com/apache/camel/pull/3987#issuecomment-656153505


   @oscerd - thank you for the quick response and review.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd merged pull request #3987: [CAMEL-15285] fix broken anchors and images

Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #3987:
URL: https://github.com/apache/camel/pull/3987


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org