You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "mattyb149 (via GitHub)" <gi...@apache.org> on 2023/03/23 20:53:12 UTC

[GitHub] [nifi] mattyb149 opened a new pull request, #7081: NIFI-11337: Update PutDatabaseRecord's Max Batch Size property documentation to reflect actual behavior

mattyb149 opened a new pull request, #7081:
URL: https://github.com/apache/nifi/pull/7081

   # Summary
   
   [NIFI-11337](https://issues.apache.org/jira/browse/NIFI-11337) This PR removes the`dependsOn` from the definition of the Maximum Batch Size property as the dependency is not honored in the code. The documentation is updated to reflect the actual behavior, and the default value is changed to 1000 to avoid memory usage issues for large incoming FlowFiles. No unit tests were added as the existing tests show there is no regression.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [x] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #7081: NIFI-11337: Update PutDatabaseRecord's Max Batch Size property documentation to reflect actual behavior

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #7081:
URL: https://github.com/apache/nifi/pull/7081#issuecomment-1481895892

   Thanks @mattyb149 changes look good +1. Will let Github Actions complete and then can merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 merged pull request #7081: NIFI-11337: Update PutDatabaseRecord's Max Batch Size property documentation to reflect actual behavior

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 merged PR #7081:
URL: https://github.com/apache/nifi/pull/7081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org