You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/03/15 15:20:17 UTC
[GitHub] flink pull request #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQ...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/5704
[FLINK-8852] [sql-client] Add FLIP-6 support to SQL Client
## What is the purpose of the change
This PR adds support for the new FLIP-6 mode in the SQL Client. For now, we only test the standalone mode. But in theory the current design should work with any deployment.
## Brief change log
- Use new FLIP-6 classes similar to `CliFrontend`
- Make some methods visible in `flink-clients` for reducing duplicate code.
## Verifying this change
Updated the existing integration tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? JavaDocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-8852
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5704.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5704
----
commit d179cb885b36f20914f3e94dae602069681166c3
Author: Timo Walther <tw...@...>
Date: 2018-03-14T14:38:48Z
[FLINK-8852] [sql-client] SQL Client does not work with new FLIP-6 mode
----
---
[GitHub] flink pull request #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5704
---
[GitHub] flink issue #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQL Clien...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5704
Thanks for your review @fhueske. Since the SQL Client is in an early beta, I will merge this for now. We need more tests for different deployments in the future anyway.
---
[GitHub] flink issue #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQL Clien...
Posted by liurenjie1024 <gi...@git.apache.org>.
Github user liurenjie1024 commented on the issue:
https://github.com/apache/flink/pull/5704
LGTM
---
[GitHub] flink issue #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQL Clien...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5704
I skimmed over the changes and did not notice anything suspicious. However, I'm not familiar with the FLIP-6 submission code. I think it would be good if somebody who's more familiar with that code would have a look as well.
I tried the changes on a local FLIP-6 cluster and that worked quite well.
Best, Fabian
---
[GitHub] flink issue #5704: [FLINK-8852] [sql-client] Add FLIP-6 support to SQL Clien...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5704
Since we are not shading anything we could also use the Maven JAR plugin:
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.0.2</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>jar</goal>
</goals>
<configuration>
<classifier>sql-jar</classifier>
</configuration>
</execution>
</executions>
</plugin>
```
---