You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Kouhei Sutou (Jira)" <ji...@apache.org> on 2019/12/04 00:12:00 UTC
[jira] [Resolved] (ARROW-7289) [C#] ListType constructor argument
is redundant
[ https://issues.apache.org/jira/browse/ARROW-7289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kouhei Sutou resolved ARROW-7289.
---------------------------------
Fix Version/s: 1.0.0
Resolution: Fixed
Issue resolved by pull request 5931
[https://github.com/apache/arrow/pull/5931]
> [C#] ListType constructor argument is redundant
> -----------------------------------------------
>
> Key: ARROW-7289
> URL: https://issues.apache.org/jira/browse/ARROW-7289
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C#
> Affects Versions: 0.15.1
> Reporter: Takashi Hashida
> Assignee: Takashi Hashida
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/arrow/blob/master/csharp/src/Apache.Arrow/Types/ListType.cs#L28]
>
> The ListType constructor has two arguments but 'ValueDataType' can be determined by 'Filed.DataType' and 'ValueFiled' can be created by valueDataType.
> It seems to me that the constructor should be separated to "ListType(Field valueField)" and " ListType(IArrowType valueDataType)".
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)