You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/09 03:56:18 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2049: [KYUUBI #1978] Support NEGOTIATE/BASIC authorization for restful frontend service

yaooqinn commented on a change in pull request #2049:
URL: https://github.com/apache/incubator-kyuubi/pull/2049#discussion_r822266214



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -197,6 +197,19 @@ object KyuubiConf {
     .stringConf
     .createOptional
 
+  val SERVER_SPNEGO_KEYTAB: ConfigEntry[Option[String]] = buildConf("spnego.keytab")
+    .doc("Keytab file for SPNego principal")
+    .version("1.5.0")
+    .fallbackConf(SERVER_KEYTAB)

Review comment:
       why it is not optional?

##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -197,6 +197,19 @@ object KyuubiConf {
     .stringConf
     .createOptional
 
+  val SERVER_SPNEGO_KEYTAB: ConfigEntry[Option[String]] = buildConf("spnego.keytab")
+    .doc("Keytab file for SPNego principal")
+    .version("1.5.0")

Review comment:
       1.6




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org