You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by Walter Underwood <wu...@wunderwood.org> on 2021/04/30 01:04:21 UTC

Re: SOLR-15056 circuit breaker bugfix?

I made a PR three days ago and linked it in the Jira.

https://github.com/apache/solr/pull/96/files

wunder
Walter Underwood
wunder@wunderwood.org
http://observer.wunderwood.org/  (my blog)

> On Mar 23, 2021, at 2:33 PM, Anshum Gupta <an...@anshumgupta.net> wrote:
> 
> Hi Walter,
> 
> Can you please create a PR, as Ab mentioned in the JIRA. That would make it much easier to review considering the size of the patch. It will also be easier to comment and iterate that way.
> 
> -Anshum
> 
> On Tue, Mar 23, 2021 at 2:24 PM Walter Underwood <wunder@wunderwood.org <ma...@wunderwood.org>> wrote:
> The patch for SOLR-15056 was submitted over two months ago. It fixes a bug, adds a new kind of circuit breaker, improves the documentation, and has unit tests.
> 
> I’ll make it into a PR if that is required, bit it is discouraging to put a bunch of work into a fix and have it ignored. This is a much better submission than the bar in Yonik’s Law of Patches.
> 
> https://issues.apache.org/jira/browse/SOLR-15056 <https://issues.apache.org/jira/browse/SOLR-15056>
> 
> wunder
> Walter Underwood
> wunder@wunderwood.org <ma...@wunderwood.org>
> http://observer.wunderwood.org/ <http://observer.wunderwood.org/>  (my blog)
> 
> 
> 
> -- 
> Anshum Gupta