You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Stian Soiland-Reyes <st...@apache.org> on 2015/03/06 17:34:44 UTC
Re: Git Push Summary
As followers on the popular commits mailing list might have spotted, I
added the "dependency activity" to incubator-taverna-common-activities
- I forgot this behind in the original repository.
This is not really an activity, but just an abstract superclass that
now in Taverna 3 is only used by Beanshell Activity (it was also used
by API Consumer Activity).
I therefore moved it into the beanshell-activity:
https://github.com/apache/incubator-taverna-common-activities/tree/master/taverna-beanshell-activity/src/main/java/net/sf/taverna/t2/activities/dependencyactivity
Note that bits of this logic don't seem to be quite right -
On 6 March 2015 at 16:09, <st...@apache.org> wrote:
> Repository: incubator-taverna-common-activities
> Updated Tags: refs/tags/old/dependency-activity-0.6 [created] e04738d83
> refs/tags/old/dependency-activity-0.7 [created] cea3a4296
> refs/tags/old/dependency-activity-0.8 [created] 48e4d97b4
> refs/tags/old/dependency-activity-0.9 [created] d5389ddfa
> refs/tags/old/dependency-activity-1.0 [created] 7259bc762
> refs/tags/old/dependency-activity-1.0.1 [created] f3ab369c6
> refs/tags/old/dependency-activity-1.1 [created] c6b983145
> refs/tags/old/dependency-activity-1.2 [created] e7b4364c9
> refs/tags/old/dependency-activity-1.3 [created] 947b75cfa
> refs/tags/old/dependency-activity-1.4 [created] 8378cad2d
> refs/tags/old/dependency-activity-1.5 [created] 9056c1451
> refs/tags/old/dependency-activity-2.0.0 [created] 2a17fb740
> refs/tags/old/dependency-activity-maintenance-2010-09-06 [created] ac10a0d89
> refs/tags/old/dependency-activity-pre-incubator-20150306 [created] eaa15e216
--
Stian Soiland-Reyes
Apache Taverna (incubating)
http://orcid.org/0000-0001-9842-9718
Re: Git Push Summary
Posted by Stian Soiland-Reyes <st...@apache.org>.
Right - it sounds like something the platform+engine should be sorting
out before starting the workflow.
On 6 March 2015 at 16:58, alaninmcr <al...@googlemail.com> wrote:
> On 06/03/2015 16:38, Stian Soiland-Reyes wrote:
>>
>> Never mind the logic question.. I Was looking at
>>
>>
>> https://github.com/apache/incubator-taverna-common-activities/blob/master/taverna-beanshell-activity/src/main/java/net/sf/taverna/t2/activities/dependencyactivity/AbstractAsynchronousDependencyActivity.java#L267
>>
>> ..which seems to build a big dependency list for every dependency
>> activity in the workflow - even if the classloader sharing is not set
>> to "workflow". But the only other option now in the enum is "system"
>> which would still cover the whole workflow.
>
>
> Yes. That code almost certainly should be replaced - especially as it is not
> clear how (if?) it will work with OSGi.
>
> It caused problems with the components and trying to ensure that they worked
> correctly where the component's realizing workflow (directly or indirectly)
> contained a beanshell with dependencies.
>
> Alan
>
--
Stian Soiland-Reyes
Apache Taverna (incubating)
http://orcid.org/0000-0001-9842-9718
Re: Git Push Summary
Posted by alaninmcr <al...@googlemail.com>.
On 06/03/2015 16:38, Stian Soiland-Reyes wrote:
> Never mind the logic question.. I Was looking at
>
> https://github.com/apache/incubator-taverna-common-activities/blob/master/taverna-beanshell-activity/src/main/java/net/sf/taverna/t2/activities/dependencyactivity/AbstractAsynchronousDependencyActivity.java#L267
>
> ..which seems to build a big dependency list for every dependency
> activity in the workflow - even if the classloader sharing is not set
> to "workflow". But the only other option now in the enum is "system"
> which would still cover the whole workflow.
Yes. That code almost certainly should be replaced - especially as it is
not clear how (if?) it will work with OSGi.
It caused problems with the components and trying to ensure that they
worked correctly where the component's realizing workflow (directly or
indirectly) contained a beanshell with dependencies.
Alan
Re: Git Push Summary
Posted by Stian Soiland-Reyes <st...@apache.org>.
Never mind the logic question.. I Was looking at
https://github.com/apache/incubator-taverna-common-activities/blob/master/taverna-beanshell-activity/src/main/java/net/sf/taverna/t2/activities/dependencyactivity/AbstractAsynchronousDependencyActivity.java#L267
..which seems to build a big dependency list for every dependency
activity in the workflow - even if the classloader sharing is not set
to "workflow". But the only other option now in the enum is "system"
which would still cover the whole workflow.
On 6 March 2015 at 16:34, Stian Soiland-Reyes <st...@apache.org> wrote:
> As followers on the popular commits mailing list might have spotted, I
> added the "dependency activity" to incubator-taverna-common-activities
> - I forgot this behind in the original repository.
>
> This is not really an activity, but just an abstract superclass that
> now in Taverna 3 is only used by Beanshell Activity (it was also used
> by API Consumer Activity).
>
> I therefore moved it into the beanshell-activity:
>
> https://github.com/apache/incubator-taverna-common-activities/tree/master/taverna-beanshell-activity/src/main/java/net/sf/taverna/t2/activities/dependencyactivity
>
>
> Note that bits of this logic don't seem to be quite right -
>
> On 6 March 2015 at 16:09, <st...@apache.org> wrote:
>> Repository: incubator-taverna-common-activities
>> Updated Tags: refs/tags/old/dependency-activity-0.6 [created] e04738d83
>> refs/tags/old/dependency-activity-0.7 [created] cea3a4296
>> refs/tags/old/dependency-activity-0.8 [created] 48e4d97b4
>> refs/tags/old/dependency-activity-0.9 [created] d5389ddfa
>> refs/tags/old/dependency-activity-1.0 [created] 7259bc762
>> refs/tags/old/dependency-activity-1.0.1 [created] f3ab369c6
>> refs/tags/old/dependency-activity-1.1 [created] c6b983145
>> refs/tags/old/dependency-activity-1.2 [created] e7b4364c9
>> refs/tags/old/dependency-activity-1.3 [created] 947b75cfa
>> refs/tags/old/dependency-activity-1.4 [created] 8378cad2d
>> refs/tags/old/dependency-activity-1.5 [created] 9056c1451
>> refs/tags/old/dependency-activity-2.0.0 [created] 2a17fb740
>> refs/tags/old/dependency-activity-maintenance-2010-09-06 [created] ac10a0d89
>> refs/tags/old/dependency-activity-pre-incubator-20150306 [created] eaa15e216
>
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating)
> http://orcid.org/0000-0001-9842-9718
--
Stian Soiland-Reyes
Apache Taverna (incubating)
http://orcid.org/0000-0001-9842-9718