[tomcat] 04/04: Additional false positives

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 46d81a2019d5c190d8e43f8f5bb1c8b79f7cad8a
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon May 22 17:31:00 2023 +0100

    Additional false positives
---
 res/spotbugs/filter-false-positives.xml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index d9a5ba4332..9794f86322 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -812,6 +812,12 @@
     <Method name="createSecureRandom"/>
     <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
   </Match>
+  <Match>
+    <!--  Thread start is intentional in back-port -->
+    <Class name="org.apache.catalina.util.TimeBucketCounter"/>
+    <Method name="&lt;init&gt;"/>
+    <Bug pattern="SC_START_IN_CTOR"/>
+  </Match>
   <Match>
     <!-- the platform default encoding is a fallback -->
     <Class name="org.apache.catalina.util.URLEncoder"/>
@@ -2550,6 +2556,12 @@
     <Method name="doCreateString" />
     <Bug pattern="UC_USELESS_OBJECT" />
   </Match>
+  <Match>
+    <!-- Should not happen. NPE is fine if it does. -->
+    <Class name="org.apache.tomcat.util.http.parser.TesterHttpWgStructuredField"/>
+    <Method name="doTestDirectory"/>
+    <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
+  </Match>
   <Match>
     <!-- Return value ignored because an exception is expected -->
     <Class name="org.apache.tomcat.util.net.TestTLSClientHelloExtractor" />


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org