You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/01/18 22:23:14 UTC
Review Request 42470: Multiple Disk: Added 'Source' to
'Resource.DiskInfo'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42470/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4378
https://issues.apache.org/jira/browse/MESOS-4378
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
Diff: https://reviews.apache.org/r/42470/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42470: Multiple Disk: Added 'Source' to
'Resource.DiskInfo'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42470/#review115323
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 20, 2016, 2:28 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42470/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 2:28 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4378
> https://issues.apache.org/jira/browse/MESOS-4378
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
> include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
>
> Diff: https://reviews.apache.org/r/42470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42470: Multiple Disk: Added 'Source' to
'Resource.DiskInfo'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42470/#review115646
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 21, 2016, 7:35 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42470/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 7:35 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4378
> https://issues.apache.org/jira/browse/MESOS-4378
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
> include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
>
> Diff: https://reviews.apache.org/r/42470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42470: Multiple Disk: Added 'Source' to
'Resource.DiskInfo'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42470/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 7:35 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Added `Mount` type.
Bugs: MESOS-4378
https://issues.apache.org/jira/browse/MESOS-4378
Repository: mesos
Description
-------
Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.
Diffs (updated)
-----
include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
Diff: https://reviews.apache.org/r/42470/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42470: Multiple Disk: Added 'Source' to
'Resource.DiskInfo'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42470/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 2:28 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4378
https://issues.apache.org/jira/browse/MESOS-4378
Repository: mesos
Description (updated)
-------
Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.
Diffs (updated)
-----
include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
Diff: https://reviews.apache.org/r/42470/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42470: Multiple Disk: Added 'Source' to
'Resource.DiskInfo'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42470/#review115257
-----------------------------------------------------------
include/mesos/mesos.proto (line 646)
<https://reviews.apache.org/r/42470/#comment176171>
Can we punt on that field for now for MVP?
I guess the goal of this field is to let the framework tell if it has exclusive access to the disk or not. I am wondering if we should use other primitives for this (e.g, ExclusiveInfo at the top level of Resource), instead of this heuristic.
My concern is that operator can potentially change the size of a directory (e.g., using lvm with some filesystem), which will make this field not so reliable.
include/mesos/v1/mesos.proto (line 645)
<https://reviews.apache.org/r/42470/#comment176172>
Ditto.
- Jie Yu
On Jan. 18, 2016, 9:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42470/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 9:23 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4378
> https://issues.apache.org/jira/browse/MESOS-4378
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
> include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
>
> Diff: https://reviews.apache.org/r/42470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>