You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2017/10/19 19:17:04 UTC
Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/
-----------------------------------------------------------
Review request for sentry.
Bugs: sentry-1667
https://issues.apache.org/jira/browse/sentry-1667
Repository: sentry
Description
-------
Bump Jetty to v9.4.7.v20170914
Diffs
-----
pom.xml 1c055569e9176a1b1a7188b99dba5b383096bc20
sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
Diff: https://reviews.apache.org/r/63160/diff/1/
Testing
-------
Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
Thanks,
Sergio Pena
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On Oct. 19, 2017, 7:25 p.m., kalyan kumar kalvagadda wrote:
> > I'm fine with bumping up the jetty version but the only concern is that the Solr tests will be failing unitl changes for SENTRY-1475 are committed.
Agreed, probably best waiting until the Solr upgrade happens, assuming of course that it's going to get done for 2.0.0?
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/#review188735
-----------------------------------------------------------
On Oct. 19, 2017, 7:17 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63160/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 7:17 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: sentry-1667
> https://issues.apache.org/jira/browse/sentry-1667
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump Jetty to v9.4.7.v20170914
>
>
> Diffs
> -----
>
> pom.xml 1c055569e9176a1b1a7188b99dba5b383096bc20
> sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
> sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
>
>
> Diff: https://reviews.apache.org/r/63160/diff/1/
>
>
> Testing
> -------
>
> Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
> On Oct. 19, 2017, 7:25 p.m., kalyan kumar kalvagadda wrote:
> > I'm fine with bumping up the jetty version but the only concern is that the Solr tests will be failing unitl changes for SENTRY-1475 are committed.
>
> Colm O hEigeartaigh wrote:
> Agreed, probably best waiting until the Solr upgrade happens, assuming of course that it's going to get done for 2.0.0?
I can sync with SENTRY-1475 and wait to commit this until a patch is available. The thing is that SENTRY-1475 needs Jetty9 to work, so we are in a chicken and egg problem. Unless we bump Jetty9 in the same SENTRY-1475 patch.
Which one is better?
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/#review188735
-----------------------------------------------------------
On Oct. 19, 2017, 7:17 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63160/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 7:17 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: sentry-1667
> https://issues.apache.org/jira/browse/sentry-1667
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump Jetty to v9.4.7.v20170914
>
>
> Diffs
> -----
>
> pom.xml 1c055569e9176a1b1a7188b99dba5b383096bc20
> sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
> sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
>
>
> Diff: https://reviews.apache.org/r/63160/diff/1/
>
>
> Testing
> -------
>
> Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/#review188735
-----------------------------------------------------------
I'm fine with bumping up the jetty version but the only concern is that the Solr tests will be failing unitl changes for SENTRY-1475 are committed.
- kalyan kumar kalvagadda
On Oct. 19, 2017, 7:17 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63160/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 7:17 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: sentry-1667
> https://issues.apache.org/jira/browse/sentry-1667
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump Jetty to v9.4.7.v20170914
>
>
> Diffs
> -----
>
> pom.xml 1c055569e9176a1b1a7188b99dba5b383096bc20
> sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
> sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
>
>
> Diff: https://reviews.apache.org/r/63160/diff/1/
>
>
> Testing
> -------
>
> Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
> On Oct. 22, 2017, 10:12 a.m., Colm O hEigeartaigh wrote:
> > Is the indentation change to "sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provide
> > r/db/service/thrift/TestSentryWebServerWithKerberos.java" intentional?
It is not. I accidentally left those spaces.
I updated the patch to remove them.
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/#review188907
-----------------------------------------------------------
On Oct. 22, 2017, 3:27 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63160/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2017, 3:27 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: sentry-1667
> https://issues.apache.org/jira/browse/sentry-1667
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump Jetty to v9.3.21.v20170918
> (The latest version 9.4.x is not working correctly with Sentry)
>
>
> Diffs
> -----
>
> pom.xml b1a04c4772b43e61855340e568c2268a2aa93a26
> sentry-binding/sentry-binding-solr/pom.xml 9cb8d27c0343019038fa19d011dbc0cf34e431f0
> sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java 3f4a2ff7eb4e6655b516a457ba8f0329f41d0520
> sentry-tests/sentry-tests-solr/pom.xml efb708ce0ed62636b0377de3d49cd1bdaf6ff54c
> sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
>
>
> Diff: https://reviews.apache.org/r/63160/diff/3/
>
>
> Testing
> -------
>
> Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/#review188907
-----------------------------------------------------------
Is the indentation change to "sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provide
r/db/service/thrift/TestSentryWebServerWithKerberos.java" intentional?
- Colm O hEigeartaigh
On Oct. 22, 2017, 3:10 a.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63160/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2017, 3:10 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: sentry-1667
> https://issues.apache.org/jira/browse/sentry-1667
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump Jetty to v9.3.21.v20170918
> (The latest version 9.4.x is not working correctly with Sentry)
>
>
> Diffs
> -----
>
> pom.xml b1a04c4772b43e61855340e568c2268a2aa93a26
> sentry-binding/sentry-binding-solr/pom.xml 9cb8d27c0343019038fa19d011dbc0cf34e431f0
> sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java 3f4a2ff7eb4e6655b516a457ba8f0329f41d0520
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java 09ee6b4493611c055dd7e96ab8a0b747fd4eb25b
> sentry-tests/sentry-tests-solr/pom.xml efb708ce0ed62636b0377de3d49cd1bdaf6ff54c
> sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
>
>
> Diff: https://reviews.apache.org/r/63160/diff/2/
>
>
> Testing
> -------
>
> Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/#review188909
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Oct. 22, 2017, 3:27 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63160/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2017, 3:27 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: sentry-1667
> https://issues.apache.org/jira/browse/sentry-1667
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump Jetty to v9.3.21.v20170918
> (The latest version 9.4.x is not working correctly with Sentry)
>
>
> Diffs
> -----
>
> pom.xml b1a04c4772b43e61855340e568c2268a2aa93a26
> sentry-binding/sentry-binding-solr/pom.xml 9cb8d27c0343019038fa19d011dbc0cf34e431f0
> sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java 3f4a2ff7eb4e6655b516a457ba8f0329f41d0520
> sentry-tests/sentry-tests-solr/pom.xml efb708ce0ed62636b0377de3d49cd1bdaf6ff54c
> sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
>
>
> Diff: https://reviews.apache.org/r/63160/diff/3/
>
>
> Testing
> -------
>
> Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/
-----------------------------------------------------------
(Updated Oct. 22, 2017, 3:27 p.m.)
Review request for sentry.
Changes
-------
Remove empty spaces from TestSentryWebServerWithKerberos
Bugs: sentry-1667
https://issues.apache.org/jira/browse/sentry-1667
Repository: sentry
Description
-------
Bump Jetty to v9.3.21.v20170918
(The latest version 9.4.x is not working correctly with Sentry)
Diffs (updated)
-----
pom.xml b1a04c4772b43e61855340e568c2268a2aa93a26
sentry-binding/sentry-binding-solr/pom.xml 9cb8d27c0343019038fa19d011dbc0cf34e431f0
sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java 3f4a2ff7eb4e6655b516a457ba8f0329f41d0520
sentry-tests/sentry-tests-solr/pom.xml efb708ce0ed62636b0377de3d49cd1bdaf6ff54c
sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
Diff: https://reviews.apache.org/r/63160/diff/3/
Changes: https://reviews.apache.org/r/63160/diff/2-3/
Testing
-------
Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
Thanks,
Sergio Pena
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/
-----------------------------------------------------------
(Updated Oct. 22, 2017, 3:10 a.m.)
Review request for sentry.
Bugs: sentry-1667
https://issues.apache.org/jira/browse/sentry-1667
Repository: sentry
Description (updated)
-------
Bump Jetty to v9.3.21.v20170918
(The latest version 9.4.x is not working correctly with Sentry)
Diffs
-----
pom.xml b1a04c4772b43e61855340e568c2268a2aa93a26
sentry-binding/sentry-binding-solr/pom.xml 9cb8d27c0343019038fa19d011dbc0cf34e431f0
sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java 3f4a2ff7eb4e6655b516a457ba8f0329f41d0520
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java 09ee6b4493611c055dd7e96ab8a0b747fd4eb25b
sentry-tests/sentry-tests-solr/pom.xml efb708ce0ed62636b0377de3d49cd1bdaf6ff54c
sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
Diff: https://reviews.apache.org/r/63160/diff/2/
Testing
-------
Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
Thanks,
Sergio Pena
Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63160/
-----------------------------------------------------------
(Updated Oct. 22, 2017, 3:09 a.m.)
Review request for sentry.
Changes
-------
Here's a better version of the Jetty9 patch.
- Add a Jetty8 dependency on the Solr tests to be able to pass.
- Modify the SentryWebServer so that it uses jetty9 API
- Exclude jetty7 dependencyes brought by Hive
There is no other Jetty version that is used in Sentry.
Bugs: sentry-1667
https://issues.apache.org/jira/browse/sentry-1667
Repository: sentry
Description
-------
Bump Jetty to v9.4.7.v20170914
Diffs (updated)
-----
pom.xml b1a04c4772b43e61855340e568c2268a2aa93a26
sentry-binding/sentry-binding-solr/pom.xml 9cb8d27c0343019038fa19d011dbc0cf34e431f0
sentry-provider/sentry-provider-db/pom.xml 4481e080d3477c1fe4410ca3f368a0c2cc3e501b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java 3f4a2ff7eb4e6655b516a457ba8f0329f41d0520
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java 09ee6b4493611c055dd7e96ab8a0b747fd4eb25b
sentry-tests/sentry-tests-solr/pom.xml efb708ce0ed62636b0377de3d49cd1bdaf6ff54c
sentry-tests/sentry-tests-sqoop/pom.xml 05b1653b1e46790a8ad7119e78b6d3d17baa4c6d
Diff: https://reviews.apache.org/r/63160/diff/2/
Changes: https://reviews.apache.org/r/63160/diff/1-2/
Testing
-------
Only Solr tests are failing. But these should be addressed by SENTRY-1475 where Solr 6 will be used.
Thanks,
Sergio Pena