You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/07/29 07:08:50 UTC

[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2769: ARTEMIS-2414 Sync before closing file in case data loss

michaelpearce-gain commented on a change in pull request #2769: ARTEMIS-2414 Sync before closing file in case data loss
URL: https://github.com/apache/activemq-artemis/pull/2769#discussion_r308081160
 
 

 ##########
 File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/TimedSequentialFile.java
 ##########
 @@ -94,7 +93,7 @@ public void fill(int size) throws Exception {
    }
 
    @Override
-   public void delete() throws IOException, InterruptedException, ActiveMQException {
+   public void delete() throws Exception {
 
 Review comment:
   Revert this and keep explicit 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services