You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/29 22:14:51 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26051: Better error messsage for pre-common-sql providers
potiuk opened a new pull request, #26051:
URL: https://github.com/apache/airflow/pull/26051
When you are using a common-sql provider functionality such
as SQLColumnCheckOperator with a provider from before common-sql
provider was released, attempts to instatiate such provider from
commmon-sql will fail because the Hooks in those providers derive from
the old airflow.hooks.dbapi_hook.DbApiHook rather than from
airflow.providers.common.sql.hooks.sql.DbApiHook.
We cannot do much about it, simply speaking the old providers
should be upgraded to a version that supports common.sql provider.
This PR raises a message that explicitly states the error.
Closes: #26046
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26051: Better error messsage for pre-common-sql providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26051:
URL: https://github.com/apache/airflow/pull/26051#issuecomment-1231796580
Small, but useful improvement in error message :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26051: Better error messsage for pre-common-sql providers
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26051:
URL: https://github.com/apache/airflow/pull/26051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26051: Better error messsage for pre-common-sql providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26051:
URL: https://github.com/apache/airflow/pull/26051#issuecomment-1231324298
The message will be even more specific now:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26051: Better error messsage for pre-common-sql providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26051:
URL: https://github.com/apache/airflow/pull/26051#issuecomment-1231797573
Confirmed by @denimalpaca that the diagnosis was correct and error messages should make it plain obvious what the problem was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26051: Better error messsage for pre-common-sql providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26051:
URL: https://github.com/apache/airflow/pull/26051#issuecomment-1230923390
cc: @denimalpaca
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org