You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "bkietz (via GitHub)" <gi...@apache.org> on 2024/10/25 17:04:33 UTC
Re: [PR] regenerate arrow-ipc/src/gen with patched flatbuffers [arrow-rs]
bkietz commented on code in PR #6426:
URL: https://github.com/apache/arrow-rs/pull/6426#discussion_r1817058751
##########
arrow-ipc/regen.sh:
##########
@@ -140,6 +144,26 @@ for f in `ls *.rs`; do
fi
done
+# Since $FLATC might be unpatched, add assertions that we have correct struct alignment
+function add_struct_alignment_test {
Review Comment:
This seemed like a good idea but it shouldn't be necessary after we apply a patch to generated .rs (will be removed soon)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org