You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by gorkem <gi...@git.apache.org> on 2014/10/19 00:28:29 UTC
[GitHub] cordova-lib pull request: [CB-7820] cordova platfrom restore stops...
GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-lib/pull/106
[CB-7820] cordova platfrom restore stops if a platforms fails to restore
handles restoration for each platform separately so that if one fails installation for
others continues. Also makes a change on how the host is checked to allow such errors
not to completely halt the execution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gorkem/cordova-lib CB-7820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 2b8a50431af17680ebd30ddce09f7717773b54d8
Author: Gorkem Ercan <go...@gmail.com>
Date: 2014-10-18T22:27:43Z
[CB-7820] cordova platfrom restore stops if a platforms fails to restore
handles restoration for each platform separately so that if one fails installation for
others continues. Also makes a change on how the host is checked to allow such errors
not to completely halt the execution.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: [CB-7820] cordova platfrom restore stops...
Posted by gorkem <gi...@git.apache.org>.
Github user gorkem commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/106#discussion_r19126554
--- Diff: cordova-lib/src/cordova/restore.js ---
@@ -54,7 +54,22 @@ function installPlatformsFromConfigXML(cfg){
if(!targets || !targets.length ){
return Q.all('No platforms are listed in config.xml to restore');
}
- return platform('add', targets);
+
+ // Run platform add for all the platforms seperately
--- End diff --
Got a new development environment... updated now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: [CB-7820] cordova platfrom restore stops...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/106#discussion_r19124580
--- Diff: cordova-lib/src/cordova/restore.js ---
@@ -54,7 +54,22 @@ function installPlatformsFromConfigXML(cfg){
if(!targets || !targets.length ){
return Q.all('No platforms are listed in config.xml to restore');
}
- return platform('add', targets);
+
+ // Run platform add for all the platforms seperately
--- End diff --
There's a trailing whitespace here.
You're using tabs below.
There's trailing whitespace on the blank line above here too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: [CB-7820] cordova platfrom restore stops...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org