[jira] [Commented] (CB-12029) Improper slog2 use causes crashes on BB10

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582872#comment-15582872 ] 

ASF GitHub Bot commented on CB-12029:
-------------------------------------

GitHub user lquinn opened a pull request:

    https://github.com/apache/cordova-plugin-globalization/pull/52

    CB-12029 blackberry10: Remove logging code that causes crashes on BB10

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    blackberry10
    
    ### What does this PR do?
    
    Removes logging code that caused crashes.
    
    ### What testing has been done on this change?
    
    Compiled. The patch is a straightforward removal of the logging code.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    The blackberry10 globalization plugin used the slog2 API improperly,
    leading to crashes in Cordova apps that use this plugin. Remove the
    logging as the safest, simplest fix.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lquinn/cordova-plugin-globalization CB-12029cordova-plugin-globalization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-globalization/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52
    
----

----


> Improper slog2 use causes crashes on BB10
> -----------------------------------------
>
>                 Key: CB-12029
>                 URL: https://issues.apache.org/jira/browse/CB-12029
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Globalization
>         Environment: BlackBerry 10.3.2
>            Reporter: Liam Quinn
>              Labels: BlackBerry10
>
> Cordova apps using the globalization plugin may crash on BlackBerry 10 due to improper use of the slog2 native API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org