You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "prateekm (via GitHub)" <gi...@apache.org> on 2023/06/01 02:12:20 UTC

[GitHub] [samza] prateekm commented on pull request #1669: Re-factor DirDiffUtil.getDirDiff to traverse and test files once.

prateekm commented on PR #1669:
URL: https://github.com/apache/samza/pull/1669#issuecomment-1571219834

   Thanks for the improvements @asautins. cc @shekhars-li to review.
   
   FMI, is there something atypical about the job / environment that causes the getDirDiff() call to be so expensive? This should only happen once per task per commit, which is typically only once a minute, so 38% of time seems very large. Optimizations make sense regardless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org