You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/04/27 09:09:08 UTC
[GitHub] [incubator-ratis] runzhiwang opened a new pull request #69: RATIS-840. memory leak of log appender
runzhiwang opened a new pull request #69:
URL: https://github.com/apache/incubator-ratis/pull/69
refer it [RATIS-840](https://issues.apache.org/jira/browse/RATIS-840) for details
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang edited a comment on pull request #69: RATIS-840. memory leak of log appender
Posted by GitBox <gi...@apache.org>.
runzhiwang edited a comment on pull request #69:
URL: https://github.com/apache/incubator-ratis/pull/69#issuecomment-620986450
@szetszwo @lokeshj1703 @bshashikant
I think this patch does not generate new failed UT.
I trigger CI several times, all the [failed UT](https://github.com/runzhiwang/incubator-ratis/runs/628048866) are in the list of [RATIS-863](https://issues.apache.org/jira/browse/RATIS-863). I together with @bshashikant summary all the failed UT generated by ratis/master in RATIS-863.
Besides, the failed UT in this PR has nothing to do with this patch. You can find the reason in [RATIS-912](https://issues.apache.org/jira/browse/RATIS-912)
I delete the following assert, because when we restart new LogAppender, the old LogAppender maybe still alive, because we do not wait old LogAppender turn dead before start new LogAppender.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #69: [WIP]RATIS-840. memory leak of log appender
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #69:
URL: https://github.com/apache/incubator-ratis/pull/69#issuecomment-620986450
@szetszwo @lokeshj1703 @bshashikant
I think this patch does not generate new failed UT.
I trigger CI several times, all the [failed UT](https://github.com/runzhiwang/incubator-ratis/runs/628048866) are in the list of [RATIS-863](https://issues.apache.org/jira/browse/RATIS-863). I together with @bshashikant summary all the failed UT generated by ratis/master in RATIS-863.
Besides, the failed UT in this PR has nothing to do with this patch. You can find the reason in [RATIS-912](https://issues.apache.org/jira/browse/RATIS-912)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org