You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "PengZheng (via GitHub)" <gi...@apache.org> on 2023/05/28 11:40:55 UTC

[I] Bundle update failure corrupts bundle archive. (celix)

PengZheng opened a new issue, #562:
URL: https://github.com/apache/celix/issues/562

   The current implementation of `celix_bundleArchive_extractBundle` removes the old bundle resource directory before extracting the zip.
   Therefore an update with a bad zip file will leave the bundle in cache unusable.
   
   Ideally, we should extract zip file to an temporary directory, atomically exchange the original resource directory and the temporary one if the extraction succeeds, and finally remove the temporary directory. Directory atomic exchange can be done with the help of the Linux-specific `renameat2` or the macOS specific `renamex_np`. 
   
   I will send a PR solving this issue with a new directory swapping API in celix_file_utils.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Bundle update failure corrupts bundle archive. (celix)

Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on issue #562:
URL: https://github.com/apache/celix/issues/562#issuecomment-1568268999

   Corrupt cache is recoverable. Such improvement is unnecessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Bundle update failure corrupts bundle archive. (celix)

Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng closed issue #562: Bundle update failure corrupts bundle archive.
URL: https://github.com/apache/celix/issues/562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org