You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2017/07/05 18:35:01 UTC
Re: Review Request 59739: Replaced use of `net::IPNetwork` by
`net::IP::Network`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59739/#review179674
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 29, 2017, 11:24 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59739/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 11:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced use of `net::IPNetwork` by `net::IP::Network`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/posix/ip.hpp 0d7e85a4b4b8263691dfb7654835312bbd117db6
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp b386fbed17698dd6c59bc6c53edfe8a7ece6a3eb
> src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp ce795628f19f0e8138ad9a0b50b7d644b9d734a8
> src/tests/containerizer/cni_isolator_tests.cpp 17afdf45a839bb80aa19663f97eaebec332ceee8
> src/tests/utils.hpp a2ae43c6a20ab3753a3501d8ce23ffb0f6ac0005
> src/tests/utils.cpp 053976d3c4cf120ff5e7dff6e96c6862a5b617b1
>
>
> Diff: https://reviews.apache.org/r/59739/diff/5/
>
>
> Testing
> -------
>
> make.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 59739: Replaced use of `net::IPNetwork` by
`net::IP::Network`.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 5, 2017, 6:35 p.m., Benjamin Hindman wrote:
> > Ship It!
I'll split this into a Stout and Mesos commit for you!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59739/#review179674
-----------------------------------------------------------
On June 29, 2017, 11:24 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59739/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 11:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced use of `net::IPNetwork` by `net::IP::Network`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/posix/ip.hpp 0d7e85a4b4b8263691dfb7654835312bbd117db6
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp b386fbed17698dd6c59bc6c53edfe8a7ece6a3eb
> src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp ce795628f19f0e8138ad9a0b50b7d644b9d734a8
> src/tests/containerizer/cni_isolator_tests.cpp 17afdf45a839bb80aa19663f97eaebec332ceee8
> src/tests/utils.hpp a2ae43c6a20ab3753a3501d8ce23ffb0f6ac0005
> src/tests/utils.cpp 053976d3c4cf120ff5e7dff6e96c6862a5b617b1
>
>
> Diff: https://reviews.apache.org/r/59739/diff/5/
>
>
> Testing
> -------
>
> make.
>
>
> Thanks,
>
> Avinash sridharan
>
>