You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2020/05/06 09:39:34 UTC

[GitHub] [syncope] mmoayyed opened a new pull request #183: NOJIRA: skipTests profile should also apply to ITs

mmoayyed opened a new pull request #183:
URL: https://github.com/apache/syncope/pull/183


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on pull request #183:
URL: https://github.com/apache/syncope/pull/183#issuecomment-624548048


   I see, but when using `-PskipTests` IT Cases are already not executed, even without the change proposed in this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] mmoayyed commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

Posted by GitBox <gi...@apache.org>.
mmoayyed commented on pull request #183:
URL: https://github.com/apache/syncope/pull/183#issuecomment-624567229


   Tested again; Seems like I might have had some local profile changes messing up the build. Change is unnecessary as was pointed out. Closing. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] mmoayyed commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

Posted by GitBox <gi...@apache.org>.
mmoayyed commented on pull request #183:
URL: https://github.com/apache/syncope/pull/183#issuecomment-624551455


   hmmm, that's odd. I wonder if this may be caused by a conflict between the build and my local maven settings. I do see ITs run when I run with that profile, using `-PskipTests,all`. I will remove/reset local changes to try again. Will report back shortly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on pull request #183:
URL: https://github.com/apache/syncope/pull/183#issuecomment-624553822


   This is so true that we use such profile for initial Travis CI step: https://github.com/apache/syncope/blob/master/.travis.yml#L51


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] mmoayyed commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

Posted by GitBox <gi...@apache.org>.
mmoayyed commented on pull request #183:
URL: https://github.com/apache/syncope/pull/183#issuecomment-624546691


   I would like `clean install -PskipTests`s to complete as quickly as possible, skipping as many tests as possible. It also seems strange that I can specify skipping tests, but in fact, only certain type of tests are skipped. Skipping tests should mean skipping tests, no surprises :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on pull request #183:
URL: https://github.com/apache/syncope/pull/183#issuecomment-624545678


   @mmoayyed any reason why you need this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org