You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/01/04 09:36:07 UTC
Re: Review Request 41671: LENS-735 : Remove accepting TableReferences
for ReferenceDimAttribute
> On Dec. 24, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, lines 99-108
> > <https://reviews.apache.org/r/41671/diff/1/?file=1175164#file1175164line99>
> >
> > Do we have test cases around this?
Yes. There are testcases.
> On Dec. 24, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java, lines 100-109
> > <https://reviews.apache.org/r/41671/diff/1/?file=1175135#file1175135line100>
> >
> > The addition of `throws` seems redundant.
Removing all redundant throws clauses.
> On Dec. 24, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java, line 171
> > <https://reviews.apache.org/r/41671/diff/1/?file=1175135#file1175135line171>
> >
> > Can we wrap HiveException in LensException?
throws HiveException was redundant. Removed that.
> On Dec. 24, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, line 582
> > <https://reviews.apache.org/r/41671/diff/1/?file=1175145#file1175145line582>
> >
> > Whrerever we're changing `throws HiveException` to `throws HiveException and LensException`, it'd be good to look inside and try to wrap `HiveException` in `LensException` wherever possible.
Created https://issues.apache.org/jira/browse/LENS-911
> On Dec. 24, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java, line 116
> > <https://reviews.apache.org/r/41671/diff/1/?file=1175153#file1175153line116>
> >
> > Any changes in this file other than renaming? Seems like reviewboard is showing this file as deleted and re-added.
Other main change : Removes the support for taking List<TableReferences> and only accepts chain columns.
> On Dec. 24, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, line 750
> > <https://reviews.apache.org/r/41671/diff/1/?file=1175159#file1175159line750>
> >
> > Do we need a log or something in else?
All tables are added now - including cube. We need to add storage filter for all dimensions. Logging is not required. I'm adding comments.
> On Dec. 24, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, line 751
> > <https://reviews.apache.org/r/41671/diff/1/?file=1175159#file1175159line751>
> >
> > Not assuming anymore.
Removed the comment.
> On Dec. 24, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, line 1067
> > <https://reviews.apache.org/r/41671/diff/1/?file=1175159#file1175159line1067>
> >
> > Seems the patch doesn't apply on master now. Probably conflicts with LENS-552.
Updated to master
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41671/#review111834
-----------------------------------------------------------
On Dec. 23, 2015, 5:42 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41671/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2015, 5:42 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-735
> https://issues.apache.org/jira/browse/LENS-735
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include the following :
>
> - Remove the option to specify TableReferences for reference in xsd. Now we accept only chain ref columns
> - Updated the same in all corresponding classes
> - Removed unnecessary code from JoinResolver. Also did some refactoring for join related classes
> - Updated existing tests to use chain ref columns
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 4092133
> lens-cli/src/test/resources/sample-cube.xml d72d279
> lens-cli/src/test/resources/test-dimension.xml 6eb3d31
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java 88c9ee8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java da3a7e5
> lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java bd4ae57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ColumnMeasure.java 5fda721
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java f09da37
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java b04532f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimAttribute.java 26c24de
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java cd80d64
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java dd0adb7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMeasure.java d5fc0e7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java e7550ca
> lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 681aa7b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java 27cbc30
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java da87e31
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java c4c3e9b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HierarchicalDimAttribute.java 698a390
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 6250905
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java c51b489
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java fa230ef
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603
> lens-cube/src/main/java/org/apache/lens/cube/metadata/join/JoinPath.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/join/TableRelationship.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 9472506
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 4034a54
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a
> lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ab7a6d8
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java d9a8249
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java 5a294af
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 67b3f40
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a83d09
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinUtils.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 0fef13f
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbe
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 9a08735
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java d9e442d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d69635d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java b7372f1
> lens-examples/src/main/resources/sales-cube.xml 7ec2ec7
> lens-examples/src/main/resources/sample-cube.xml 7b784ea
> lens-examples/src/main/resources/sample-db-only-dimension.xml 4c6bec6
> lens-examples/src/main/resources/sample-dimension.xml 9b97da7
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 817c84c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e0c0923
> lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java 03b8d43
> lens-storage-db/src/test/java/org/apache/lens/storage/db/TestDBStorage.java 92a0027
>
> Diff: https://reviews.apache.org/r/41671/diff/
>
>
> Testing
> -------
>
> Few more tests in lens-cube are failing. Will fix and upload next patch.
>
> Pending:
> - Verify examples
> - and full test suite.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>