You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2011/06/10 23:13:58 UTC

[jira] [Created] (HIVE-2215) Add api for marking / querying set of partitions for events

Add api for marking / querying set of partitions for events
-----------------------------------------------------------

                 Key: HIVE-2215
                 URL: https://issues.apache.org/jira/browse/HIVE-2215
             Project: Hive
          Issue Type: New Feature
          Components: Metastore
    Affects Versions: 0.8.0
            Reporter: Ashutosh Chauhan
            Assignee: Ashutosh Chauhan
             Fix For: 0.8.0




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047506#comment-13047506 ] 

Ashutosh Chauhan commented on HIVE-2215:
----------------------------------------

Replying to Paul's comments since I closed HIVE-2147 :

bq. I agree with John's suggestion for PARTITION_EVENTS. For this event table, when will rows be dropped?
This also needs to be considered. I will prefer to do it in a followup jira to keep this one manageable.

bq. Also, for when partitions are represented using a string, we've followed the convention that they are called partition names. Can we use that for MPartitionSet?
Yup, I can rename that.

bq. Since MPartitionSet.partVals is a string, we should make it indexed, much like partitionName for the PARTITION table.
In the latest patch, I have made it indexed.

If you can take a look at the latest patch, that will be great.

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048848#comment-13048848 ] 

Carl Steinbach commented on HIVE-2215:
--------------------------------------

I'm working on some comments right now. I'll have them posted in an hour.

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104235#comment-13104235 ] 

Hudson commented on HIVE-2215:
------------------------------

Integrated in Hive-0.8.0-SNAPSHOT-h0.21 #20 (See [https://builds.apache.org/job/Hive-0.8.0-SNAPSHOT-h0.21/20/])
    HIVE-2441. Metastore upgrade scripts for schema change introduced in HIVE-2215 (Ashutosh Chauhan via cws)

cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170346
Files : 
* /hive/branches/branch-0.8/metastore/scripts/upgrade/derby/009-HIVE-2215.derby.sql
* /hive/branches/branch-0.8/metastore/scripts/upgrade/mysql/009-HIVE-2215.mysql.sql
* /hive/branches/branch-0.8/metastore/scripts/upgrade/postgres/009-HIVE-2215.postgres.sql


> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive-2215_full-1.patch, hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2215:
-----------------------------------

    Status: Patch Available  (was: Open)

This patch is ready for review.

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047466#comment-13047466 ] 

jiraposter@reviews.apache.org commented on HIVE-2215:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/883/
-----------------------------------------------------------

Review request for hive and John Sichi.


Summary
-------

Follow-up for HIVE-2147.


This addresses bug HIVE-2215.
    https://issues.apache.org/jira/browse/HIVE-2215


Diffs
-----

  trunk/metastore/if/hive_metastore.thrift 1134443 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1134443 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1134443 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1134443 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1134443 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1134443 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1134443 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/MarkPartitionEvent.java PRE-CREATION 
  trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java PRE-CREATION 
  trunk/metastore/src/model/package.jdo 1134443 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1134443 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionSet.java PRE-CREATION 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1134443 

Diff: https://reviews.apache.org/r/883/diff


Testing
-------

Added test cases for new api.


Thanks,

Ashutosh



> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048925#comment-13048925 ] 

jiraposter@reviews.apache.org commented on HIVE-2215:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/883/#review824
-----------------------------------------------------------



trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/883/#comment1784>

    I think this should be changed to "PartitionEventType" in order to make it clear that this applies to partitions only. If in the future we need to introduce event types for tables, indexes, etc, then we should add new enums for those event types as well.



trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/883/#comment1785>

    This should also throw UnknownDBException and UnknownTableException. The same goes for isPartitionMarkedForEvent.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/883/#comment1786>

    Collections aren't required to satisfy an ordering property, so we have to assume the output of this logging statement is ambiguous, e.g. "[a, b]" versus "[b, a]". We should disambiguate this by passing in the part_vals map and logging the key/value pairs instead of just the values.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/883/#comment1789>

    Missing exceptions: UnknownDbException and UnknownTableException.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/883/#comment1787>

    Checking to see if the DB and Table exist should be done in the same database transaction as the rest of the operation. If you do it here there's no guarantee that the db/table will still exist when ms.markPartitionForEvent() is called.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/883/#comment1791>

    Should we add an InvalidPartitionException and UnknownPartitionException? Seems like those are both valid exceptions in this situation.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/883/#comment1788>

    Same issue here as before. These checks need to get pushed into ms.isPartitionMarkedForEvent().



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
<https://reviews.apache.org/r/883/#comment1798>

    I think the name of this method is misleading. You're marking a single partition done, not a set of partitions, right? 
    
    Also, in this context being "done" means that the load operation on that partition has completed, so it would be good to include "load" in the name of the method and event class, e.g. "LoadPartitionDoneEvent" and "onLoadPartitionDone".
    



trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java
<https://reviews.apache.org/r/883/#comment1800>

    Is it possible to use org.apache.hadoop.hive.metastore.api.EventType instead of int?
    
    Another approach is to create an MPartitionEvent baseclass, and then subclass that with MPartitionLoadDoneEvent, etc, and use eventType as the internal type discriminator for JDO.



trunk/metastore/src/model/package.jdo
<https://reviews.apache.org/r/883/#comment1793>

    You need to supply schema upgrade scripts for Derby and MySQL. Please either do that in this ticket or open a followup ticket and assign it to yourself.



trunk/metastore/src/model/package.jdo
<https://reviews.apache.org/r/883/#comment1799>

    It looks like it's possible for this table to hold more than one "MarkPartitionDone" event for the same partition, but is that a legal state? If it is, how do you know when the load operation for a partition is still in progress?



trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionSet.java
<https://reviews.apache.org/r/883/#comment1801>

    Can you subclass this with a remote and embedded version?



trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
<https://reviews.apache.org/r/883/#comment1797>

    Any reason in particular why you switched to always running this test in local mode? If we can only test one scenario, then I think there's more value in focusing on the standalone client/server setup.


- Carl


On 2011-06-10 21:24:13, Ashutosh Chauhan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/883/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-06-10 21:24:13)
bq.  
bq.  
bq.  Review request for hive and John Sichi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Follow-up for HIVE-2147.
bq.  
bq.  
bq.  This addresses bug HIVE-2215.
bq.      https://issues.apache.org/jira/browse/HIVE-2215
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/if/hive_metastore.thrift 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/MarkPartitionEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/package.jdo 1134443 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1134443 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionSet.java PRE-CREATION 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1134443 
bq.  
bq.  Diff: https://reviews.apache.org/r/883/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added test cases for new api.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ashutosh
bq.  
bq.



> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048810#comment-13048810 ] 

John Sichi commented on HIVE-2215:
----------------------------------

Carl, any comments on the latest?


> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048804#comment-13048804 ] 

jiraposter@reviews.apache.org commented on HIVE-2215:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/883/#review822
-----------------------------------------------------------



trunk/metastore/src/model/package.jdo
<https://reviews.apache.org/r/883/#comment1782>

    Does indexing actually work on a LONGVARCHAR field across all DB's of interest?


- John


On 2011-06-10 21:24:13, Ashutosh Chauhan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/883/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-06-10 21:24:13)
bq.  
bq.  
bq.  Review request for hive and John Sichi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Follow-up for HIVE-2147.
bq.  
bq.  
bq.  This addresses bug HIVE-2215.
bq.      https://issues.apache.org/jira/browse/HIVE-2215
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/if/hive_metastore.thrift 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/MarkPartitionEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/package.jdo 1134443 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1134443 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionSet.java PRE-CREATION 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1134443 
bq.  
bq.  Diff: https://reviews.apache.org/r/883/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added test cases for new api.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ashutosh
bq.  
bq.



> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049410#comment-13049410 ] 

jiraposter@reviews.apache.org commented on HIVE-2215:
-----------------------------------------------------



bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/if/hive_metastore.thrift, line 46
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20969#file20969line46>
bq.  >
bq.  >     I think this should be changed to "PartitionEventType" in order to make it clear that this applies to partitions only. If in the future we need to introduce event types for tables, indexes, etc, then we should add new enums for those event types as well.

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/if/hive_metastore.thrift, line 338
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20969#file20969line338>
bq.  >
bq.  >     This should also throw UnknownDBException and UnknownTableException. The same goes for isPartitionMarkedForEvent.

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 528
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20970#file20970line528>
bq.  >
bq.  >     Collections aren't required to satisfy an ordering property, so we have to assume the output of this logging statement is ambiguous, e.g. "[a, b]" versus "[b, a]". We should disambiguate this by passing in the part_vals map and logging the key/value pairs instead of just the values.

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 3182
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20970#file20970line3182>
bq.  >
bq.  >     Missing exceptions: UnknownDbException and UnknownTableException.

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 3186
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20970#file20970line3186>
bq.  >
bq.  >     Checking to see if the DB and Table exist should be done in the same database transaction as the rest of the operation. If you do it here there's no guarantee that the db/table will still exist when ms.markPartitionForEvent() is called.

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 3188
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20970#file20970line3188>
bq.  >
bq.  >     Should we add an InvalidPartitionException and UnknownPartitionException? Seems like those are both valid exceptions in this situation.

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 3224
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20970#file20970line3224>
bq.  >
bq.  >     Same issue here as before. These checks need to get pushed into ms.isPartitionMarkedForEvent().

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java, line 82
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20973#file20973line82>
bq.  >
bq.  >     I think the name of this method is misleading. You're marking a single partition done, not a set of partitions, right? 
bq.  >     
bq.  >     Also, in this context being "done" means that the load operation on that partition has completed, so it would be good to include "load" in the name of the method and event class, e.g. "LoadPartitionDoneEvent" and "onLoadPartitionDone".
bq.  >

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java, line 34
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20977#file20977line34>
bq.  >
bq.  >     Is it possible to use org.apache.hadoop.hive.metastore.api.EventType instead of int?
bq.  >     
bq.  >     Another approach is to create an MPartitionEvent baseclass, and then subclass that with MPartitionLoadDoneEvent, etc, and use eventType as the internal type discriminator for JDO.

No.

I don't see any benefit of it. Nor I cant see how will this work.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/model/package.jdo, line 668
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20978#file20978line668>
bq.  >
bq.  >     You need to supply schema upgrade scripts for Derby and MySQL. Please either do that in this ticket or open a followup ticket and assign it to yourself.

Will do.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/model/package.jdo, line 683
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20978#file20978line683>
bq.  >
bq.  >     It looks like it's possible for this table to hold more than one "MarkPartitionDone" event for the same partition, but is that a legal state? If it is, how do you know when the load operation for a partition is still in progress?

This is not for when load operation is in progress. As suggested from name its "LoadPartitionDone". So, marking partition load done is idempotent. Client can mark it multiple times. So, metastore will return true if it finds one or more such partitioned marked in the table.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionSet.java, line 36
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20980#file20980line36>
bq.  >
bq.  >     Can you subclass this with a remote and embedded version?

Done.


bq.  On 2011-06-14 01:02:20, Carl Steinbach wrote:
bq.  > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java, line 80
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20981#file20981line80>
bq.  >
bq.  >     Any reason in particular why you switched to always running this test in local mode? If we can only test one scenario, then I think there's more value in focusing on the standalone client/server setup.

I reverted those changes.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/883/#review824
-----------------------------------------------------------


On 2011-06-14 20:51:53, Ashutosh Chauhan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/883/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-06-14 20:51:53)
bq.  
bq.  
bq.  Review request for hive and John Sichi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Follow-up for HIVE-2147.
bq.  
bq.  
bq.  This addresses bug HIVE-2215.
bq.      https://issues.apache.org/jira/browse/HIVE-2215
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/if/hive_metastore.thrift 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/LoadPartitionDoneEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/package.jdo 1135779 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1135779 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartition.java PRE-CREATION 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java PRE-CREATION 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1135779 
bq.  
bq.  Diff: https://reviews.apache.org/r/883/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added test cases for new api.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ashutosh
bq.  
bq.



> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054057#comment-13054057 ] 

Hudson commented on HIVE-2215:
------------------------------

Integrated in Hive-trunk-h0.21 #790 (See [https://builds.apache.org/job/Hive-trunk-h0.21/790/])
    

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive-2215_full-1.patch, hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2215:
-----------------------------------

    Attachment: hive_2215.patch

Patch including generated code. Will post on RB without generated code. Incorporates feedback from John on HIVE-2147

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048808#comment-13048808 ] 

jiraposter@reviews.apache.org commented on HIVE-2215:
-----------------------------------------------------



bq.  On 2011-06-13 21:47:25, John Sichi wrote:
bq.  > trunk/metastore/src/model/package.jdo, line 670
bq.  > <https://reviews.apache.org/r/883/diff/1/?file=20978#file20978line670>
bq.  >
bq.  >     Does indexing actually work on a LONGVARCHAR field across all DB's of interest?

No, it doesn't. So, I reverted it back to VARCHAR.

If the rest of the patch looks alright, I will attach a new patch with this change.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/883/#review822
-----------------------------------------------------------


On 2011-06-10 21:24:13, Ashutosh Chauhan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/883/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-06-10 21:24:13)
bq.  
bq.  
bq.  Review request for hive and John Sichi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Follow-up for HIVE-2147.
bq.  
bq.  
bq.  This addresses bug HIVE-2215.
bq.      https://issues.apache.org/jira/browse/HIVE-2215
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/if/hive_metastore.thrift 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1134443 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/MarkPartitionEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/package.jdo 1134443 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1134443 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionSet.java PRE-CREATION 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1134443 
bq.  
bq.  Diff: https://reviews.apache.org/r/883/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added test cases for new api.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ashutosh
bq.  
bq.



> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-2215:
---------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks Ashutosh!

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive-2215_full-1.patch, hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050528#comment-13050528 ] 

Ashutosh Chauhan commented on HIVE-2215:
----------------------------------------

Anyone care to commit this one?

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive-2215_full-1.patch, hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049695#comment-13049695 ] 

jiraposter@reviews.apache.org commented on HIVE-2215:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/883/#review843
-----------------------------------------------------------

Ship it!


Looks good to me. Thanks for making the changes.

- Carl


On 2011-06-14 20:51:53, Ashutosh Chauhan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/883/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-06-14 20:51:53)
bq.  
bq.  
bq.  Review request for hive and John Sichi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Follow-up for HIVE-2147.
bq.  
bq.  
bq.  This addresses bug HIVE-2215.
bq.      https://issues.apache.org/jira/browse/HIVE-2215
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/if/hive_metastore.thrift 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1135779 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/LoadPartitionDoneEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java PRE-CREATION 
bq.    trunk/metastore/src/model/package.jdo 1135779 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1135779 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartition.java PRE-CREATION 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java PRE-CREATION 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1135779 
bq.  
bq.  Diff: https://reviews.apache.org/r/883/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added test cases for new api.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ashutosh
bq.  
bq.



> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049405#comment-13049405 ] 

jiraposter@reviews.apache.org commented on HIVE-2215:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/883/
-----------------------------------------------------------

(Updated 2011-06-14 20:51:53.179968)


Review request for hive and John Sichi.


Changes
-------

Updated patch with Carl's comments.
Carl, can you take a look?


Summary
-------

Follow-up for HIVE-2147.


This addresses bug HIVE-2215.
    https://issues.apache.org/jira/browse/HIVE-2215


Diffs (updated)
-----

  trunk/metastore/if/hive_metastore.thrift 1135779 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1135779 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1135779 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1135779 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1135779 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1135779 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1135779 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/LoadPartitionDoneEvent.java PRE-CREATION 
  trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java PRE-CREATION 
  trunk/metastore/src/model/package.jdo 1135779 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1135779 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartition.java PRE-CREATION 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java PRE-CREATION 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1135779 

Diff: https://reviews.apache.org/r/883/diff


Testing
-------

Added test cases for new api.


Thanks,

Ashutosh



> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104190#comment-13104190 ] 

Hudson commented on HIVE-2215:
------------------------------

Integrated in Hive-trunk-h0.21 #951 (See [https://builds.apache.org/job/Hive-trunk-h0.21/951/])
    HIVE-2441. Metastore upgrade scripts for schema change introduced in HIVE-2215 (Ashutosh Chauhan via cws)

cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170344
Files : 
* /hive/trunk/metastore/scripts/upgrade/derby/009-HIVE-2215.derby.sql
* /hive/trunk/metastore/scripts/upgrade/mysql/009-HIVE-2215.mysql.sql
* /hive/trunk/metastore/scripts/upgrade/postgres/009-HIVE-2215.postgres.sql


> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive-2215_full-1.patch, hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050624#comment-13050624 ] 

Carl Steinbach commented on HIVE-2215:
--------------------------------------

+1. Will commit when tests pass.

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive-2215_full-1.patch, hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2215) Add api for marking / querying set of partitions for events

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2215:
-----------------------------------

    Attachment: hive-2215_full-1.patch

Thanks, Carl for quick reply. Here is the full patch with the generated code. Can someone please commit this?

> Add api for marking / querying set of partitions for events
> -----------------------------------------------------------
>
>                 Key: HIVE-2215
>                 URL: https://issues.apache.org/jira/browse/HIVE-2215
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive-2215_full-1.patch, hive_2215.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira