[jira] [Work logged] (GOBBLIN-808) implement azkaban job cancellation in Gobblin Service

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-808?focusedWorklogId=274316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274316 ]

ASF GitHub Bot logged work on GOBBLIN-808:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Jul/19 19:41
            Start Date: 09/Jul/19 19:41
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on pull request #2674: [GOBBLIN-808] implement azkaban flow cancel when dag manager is enabled
URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r301760609
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
 ##########
 @@ -470,7 +571,9 @@ private void submitJob(DagNode<JobExecutionPlan> dagNode) {
         // The SpecProducer implementations submit the job to the underlying executor and return when the submission is complete,
         // either successfully or unsuccessfully. To catch any exceptions in the job submission, the DagManagerThread
         // blocks (by calling Future#get()) until the submission is completed.
-        producer.addSpec(jobSpec).get();
+        Future addSpecFuture = producer.addSpec(jobSpec);
+        dagNode.getValue().setJobFuture(Optional.of(addSpecFuture));
 
 Review comment:
   done
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 274316)
    Time Spent: 5h 10m  (was: 5h)

> implement azkaban job cancellation in Gobblin Service
> -----------------------------------------------------
>
>                 Key: GOBBLIN-808
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-808
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)