You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "laskoviymishka (via GitHub)" <gi...@apache.org> on 2026/10/11 09:25:09 UTC
[PR] refactor!: remove ManifestFile.FetchEntries and DataFile.DistinctValueCounts [iceberg-go]
laskoviymishka opened a new pull request, #2179:
URL: https://github.com/apache/iceberg-go/pull/2179
ManifestFile.FetchEntries loaded every entry into memory and took no context. Use ManifestFile.Entries, which streams entries as an iterator:
```
for entry, err := range mf.Entries(fs, discardDeleted) {
if err != nil {
return err
}
// use entry
}
```
or ReadManifest when a slice is needed.
DataFile.DistinctValueCounts and DataFileBuilder.DistinctValueCounts exposed distinct_counts (field 111), which the spec deprecates in every format version. Writers already omitted the field, so the setter had no effect on the wire. The Avro field stays on the data file struct, so legacy manifests that carry it still decode, and writers continue to omit it. The tests now check both on the struct, and a codec test checks that the entry schema has no field 111.
This is a breaking change for callers of the removed methods.
Part of the v1.0 API cleanup in #2062.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] refactor!: remove ManifestFile.FetchEntries and DataFile.DistinctValueCounts [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #2179:
URL: https://github.com/apache/iceberg-go/pull/2179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org