You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/29 14:08:20 UTC
[jira] [Commented] (FLINK-4528) Mark runAsync and scheduleAsync
methods protected
[ https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445976#comment-15445976 ]
ASF GitHub Bot commented on FLINK-4528:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2436
[FLINK-4528] [rpc] Marks main thread execution methods in RpcEndpoint as protected
The main thread execution methods should not be exposed to the outside world of the `RpcEndpoint`, because they are internal methods.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixAsyncMethods
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2436.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2436
----
commit 780f9c4cb4b1251fa5a7899fc3dadde694953232
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-08-29T13:49:59Z
[FLINK-4528] [rpc] Marks main thread execution methods in RpcEndpoint as protected
----
> Mark runAsync and scheduleAsync methods protected
> -------------------------------------------------
>
> Key: FLINK-4528
> URL: https://issues.apache.org/jira/browse/FLINK-4528
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> Currently, the {{runAsync}} and {{scheduleAsync}} methods of the {{RpcEndpoint}} are marked as public. I think that these methods should be protected since nobody should be able to influence the internal state of an {{RpcEndpoint}} from the outside via these methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)