You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Pavel Tupitsyn <pt...@apache.org> on 2018/02/14 21:51:48 UTC

.NET: ISslContextFactory should be empty

Igniters, Alexey, Igor,

I'd like to discuss recently added ISslContextFactory interface.
https://github.com/apache/ignite/commit/e58aae48b67c74307703d2ae44fe8e3cd4b9649a

"Factory" implies a "CreateInstace" or a similar method, see
CacheConfigurationCacheStoreFactory
or ExpiryPolicyFactory as an example.

Another case is a placeholder interface that maps to some Java abstraction
but has no .NET counterpart (yet), an example is IEvictionPolicy.

In case of ISslContextFactory we have a similar situation, so the interface
should be empty.
Key store details do not belong there.

Thoughts?

PS Please add me as a reviewer for .NET tickets

Thanks,
Pavel

Re: .NET: ISslContextFactory should be empty

Posted by Pavel Tupitsyn <pt...@apache.org>.

Since there are no objections I have removed unused interface members.

Thank you for all the replies.

On Thu, Feb 15, 2018 at 12:51 AM, Pavel Tupitsyn <pt...@apache.org>
wrote:

> Igniters, Alexey, Igor,
>
> I'd like to discuss recently added ISslContextFactory interface.
> https://github.com/apache/ignite/commit/e58aae48b67c74307703d2ae44fe8e
> 3cd4b9649a
>
> "Factory" implies a "CreateInstace" or a similar method, see
> CacheConfigurationCacheStoreFactory
> or ExpiryPolicyFactory as an example.
>
> Another case is a placeholder interface that maps to some Java abstraction
> but has no .NET counterpart (yet), an example is IEvictionPolicy.
>
> In case of ISslContextFactory we have a similar situation, so the
> interface should be empty.
> Key store details do not belong there.
>
> Thoughts?
>
> PS Please add me as a reviewer for .NET tickets
>
> Thanks,
> Pavel
>