You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chenghao-intel <gi...@git.apache.org> on 2015/02/26 08:08:03 UTC
[GitHub] spark pull request: [SPARK-6034] [SQL] Support Describe Extended (...
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/4784
[SPARK-6034] [SQL] Support Describe Extended (View/DataSourceProvider) in HiveContext
In HiveContext, describe extended [table | view | cache | datasource table] is not well supported.
This PR will cover the
```
describe extended [table | view | datasource table]
```
Still, we probably need to refactor the `catalog.lookupRelation()` a little bit for supporting `describe` the `cached table`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenghao-intel/spark hive_describe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4784
----
commit 67f65b8d2cec50eeac1d74ba89c25746eca92d34
Author: Cheng Hao <ha...@intel.com>
Date: 2015-02-26T06:50:29Z
Support Describe Extended (View/DataSourceProvider) in HiveContext
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6034] [SQL] Support Describe Extended (...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4784#issuecomment-89089368
Thanks for working on this! It would be great to have more uniform support here. However, I wonder if the implementation can't be simpler? Perhaps we could just add a `describe` method to catalog and then a simple `RunnableCommand` that just calls that. This way even if we add other types of Catalogs, we don't have to add more commands.
I propose we close this issue for now, and have a discussion about the schema for the values returned by `catalog.describe` on the JIRA. Once we have agreement would be awesome if we can target this for 1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6034] [SQL] Support Describe Extended (...
Posted by chenghao-intel <gi...@git.apache.org>.
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4784#issuecomment-89090813
Thanks, closing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6034] [SQL] Support Describe Extended (...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4784#issuecomment-76135531
[Test build #27991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27991/consoleFull) for PR 4784 at commit [`67f65b8`](https://github.com/apache/spark/commit/67f65b8d2cec50eeac1d74ba89c25746eca92d34).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` // TODO should we create the trait for MetaStoreXXXRelation(XXX = Table / View / Cache)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6034] [SQL] Support Describe Extended (...
Posted by chenghao-intel <gi...@git.apache.org>.
Github user chenghao-intel closed the pull request at:
https://github.com/apache/spark/pull/4784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6034] [SQL] Support Describe Extended (...
Posted by chhao01 <gi...@git.apache.org>.
Github user chhao01 commented on the pull request:
https://github.com/apache/spark/pull/4784#issuecomment-89877867
@marmbrus I am still wondering will that be better if we define a new logical node for `view`? As in some customer cases, they create a view first, and then scan that view multiple times within a single SQL query, we probably can add more rules for the Analyzer/Optimizer extension to do kind of `caching`. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6034] [SQL] Support Describe Extended (...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4784#issuecomment-76135536
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27991/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6034] [SQL] Support Describe Extended (...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4784#issuecomment-76132434
[Test build #27991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27991/consoleFull) for PR 4784 at commit [`67f65b8`](https://github.com/apache/spark/commit/67f65b8d2cec50eeac1d74ba89c25746eca92d34).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org