You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2025/06/25 12:49:35 UTC
[PR] Core, REST: properly close resources when catalog initialization fails [iceberg]
adutra opened a new pull request, #13384:
URL: https://github.com/apache/iceberg/pull/13384
If initialization fails, for example when fetching the config, the AuthManager won't be properly closed and will leak resources.
Same for the catalog's RESTClient or AuthSession, if some error is thrown before they are added to the CloseableGroup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, REST: properly close resources when catalog initialization fails [iceberg]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #13384:
URL: https://github.com/apache/iceberg/pull/13384#issuecomment-3005176162
Also: `CloseableGroup` is not serializable, so that would be a problem for `VendedAdlsCredentialProvider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, REST: properly close resources when catalog initialization fails [iceberg]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #13384:
URL: https://github.com/apache/iceberg/pull/13384#issuecomment-3005151177
> changes LGTM but wouldn't we have a similar issue in other places where the auth manager is used, such as `VendedAdlsCredentialsProvider`/ `OAuth2RefreshCredentialsHandler`? I think in those two classes the `CloseableGroup` should be instantiated much earlier and managed outside of the `close()` method
@nastra I think they are fine? As it stands now, in these classes, every closeable field that is written will get closed when the `close()` method is called. The `CloseableGroup` is just a trick to avoid a bunch of nested try-finally blocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org