You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/24 14:08:29 UTC

[GitHub] [tvm] junrushao commented on a diff in pull request #12450: [TIR][Schedule] enhance compute_at primitive to choose proper position

junrushao commented on code in PR #12450:
URL: https://github.com/apache/tvm/pull/12450#discussion_r953851809


##########
include/tvm/tir/schedule/schedule.h:
##########
@@ -430,9 +430,11 @@ class ScheduleNode : public runtime::Object {
    * \param block_rv The block to be moved
    * \param loop_rv The loop where the block to be moved under
    * \param preserve_unit_loops Whether to keep the trivial loops whose extents are 1
+   * \param index The block index of the loop body subtree blocks
+   * -1, -2 means keep closed to or away from it's consumer

Review Comment:
   I polished the doc a little bit. let me know if makes sense
   
   ```suggestion
      * \param index The block index of the loop body subtree blocks.
      * A nonnegative number means the index of a possible insertion point
      * -1 means inserted into the last possible insertion point
      * -2 means inserted into the first possible insertion point
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org