You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/12/03 11:49:37 UTC

[kudu-CR] java tests: Clean up and document binDir search 

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5348

to review the following change.

Change subject: java tests: Clean up and document binDir search
......................................................................

java tests: Clean up and document binDir search

This patch just does a small cleanup of the binDir search code and
documents that we purposely do not search the current working directory
for the Kudu bin directory.

Change-Id: I09765771aa49264c8f1ef9e80aafb3b577cdbe94
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
1 file changed, 37 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/5348/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09765771aa49264c8f1ef9e80aafb3b577cdbe94
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] java tests: Clean up and document binDir search

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: java tests: Clean up and document binDir search
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09765771aa49264c8f1ef9e80aafb3b577cdbe94
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] java tests: Clean up and document binDir search

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.

Change subject: java tests: Clean up and document binDir search
......................................................................


java tests: Clean up and document binDir search

This patch just does a small cleanup of the binDir search code and
documents that we purposely do not search the current working directory
for the Kudu bin directory.

Change-Id: I09765771aa49264c8f1ef9e80aafb3b577cdbe94
Reviewed-on: http://gerrit.cloudera.org:8080/5348
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
1 file changed, 37 insertions(+), 15 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09765771aa49264c8f1ef9e80aafb3b577cdbe94
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>